-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve security plugin return types #101492
Improve security plugin return types #101492
Conversation
582c495
to
2ce7f03
Compare
4e78403
to
fc89a0e
Compare
fc89a0e
to
6cfaf0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together, Stacey!
x-pack/plugins/security/public/nav_control/nav_control_service.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security/public/nav_control/nav_control_service.tsx
Outdated
Show resolved
Hide resolved
….tsx Co-authored-by: Larry Gregory <lgregorydev@gmail.com>
….tsx Co-authored-by: Larry Gregory <lgregorydev@gmail.com>
Co-authored-by: Larry Gregory <lgregorydev@gmail.com>
Co-authored-by: Larry Gregory <lgregorydev@gmail.com>
…cey-gammon/kibana into 2021-06-07-fix-security-return-types
…06-07-fix-security-return-types
💔 Backport failed
To backport manually run: |
* Add explicit security types * Remove sessionTimeout, seems unused * add comments * Add comments and fix test since removing the unused APIs * remove unused import * wording cleanup * Export some types that are part of the public API but not exported * more improvements for api docs * update security docs * Update x-pack/plugins/security/public/nav_control/nav_control_service.tsx Co-authored-by: Larry Gregory <lgregorydev@gmail.com> * Update x-pack/plugins/security/public/nav_control/nav_control_service.tsx Co-authored-by: Larry Gregory <lgregorydev@gmail.com> * Update x-pack/plugins/security/public/plugin.tsx Co-authored-by: Larry Gregory <lgregorydev@gmail.com> * Update x-pack/plugins/security/public/plugin.tsx Co-authored-by: Larry Gregory <lgregorydev@gmail.com> * remove unneccessary readonly prefix * Update all api docs Co-authored-by: Larry Gregory <lgregorydev@gmail.com> # Conflicts: # api_docs/data.json # api_docs/data_index_patterns.json # api_docs/data_search.json # api_docs/deprecations.mdx # api_docs/licensing.json # api_docs/lists.json # api_docs/triggers_actions_ui.json # api_docs/usage_collection.json
* Add explicit security types * Remove sessionTimeout, seems unused * add comments * Add comments and fix test since removing the unused APIs * remove unused import * wording cleanup * Export some types that are part of the public API but not exported * more improvements for api docs * update security docs * Update x-pack/plugins/security/public/nav_control/nav_control_service.tsx Co-authored-by: Larry Gregory <lgregorydev@gmail.com> * Update x-pack/plugins/security/public/nav_control/nav_control_service.tsx Co-authored-by: Larry Gregory <lgregorydev@gmail.com> * Update x-pack/plugins/security/public/plugin.tsx Co-authored-by: Larry Gregory <lgregorydev@gmail.com> * Update x-pack/plugins/security/public/plugin.tsx Co-authored-by: Larry Gregory <lgregorydev@gmail.com> * remove unneccessary readonly prefix * Update all api docs Co-authored-by: Larry Gregory <lgregorydev@gmail.com> # Conflicts: # api_docs/data.json # api_docs/data_index_patterns.json # api_docs/data_search.json # api_docs/deprecations.mdx # api_docs/licensing.json # api_docs/lists.json # api_docs/triggers_actions_ui.json # api_docs/usage_collection.json
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ml/data_frame_analytics/feature_importance·ts.machine learning data frame analytics total feature importance panel and decision path popover binary classification job should display the feature importance decision path in the data gridStandard Out
Stack Trace
Metrics [docs]Public APIs missing comments
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
* master: (54 commits) Implement "select all" rules feature (elastic#100554) [ML] Remove script fields from the Anomaly detection alerting rule executor (elastic#101607) [Security solutions][Endpoint] Update event filtering texts (elastic#101563) [Enterprise Search] Mocks/tests tech debt - avoid hungry mocking (elastic#101107) [FTR] Updates esArchive paths [FTR] Updates esArchive paths [Security Solution][Detection Engine] Adds runtime field tests (elastic#101664) Added APM PHP agent to the list of agent names (elastic#101062) [CI] Restore old version_info behavior when .git directory is present (elastic#101642) [Fleet] Add fleet server telemetry (elastic#101400) [APM] Syncs agent config settings to APM Fleet policies (elastic#100744) [esArchiver] drop support for --dir, use repo-relative paths instead (elastic#101345) Revert "[xpack/test] restore incremental: false in ts project" [Security Solution] Remove Host Isolation feature flag (elastic#101655) [xpack/test] restore incremental: false in ts project [DOCS] Adds link to video landing page (elastic#101413) [ML] Move Index Data Visualizer into separate plugin (Part 1) (elastic#100922) Improve security plugin return types (elastic#101492) [ts] migrate `x-pack/test` to composite ts project (elastic#101441) [App Search] Updated Search UI to new URL (elastic#101320) ...
Plugin API Changes
__legacy
andsessionTimeout
were removed from the security plugin's setup contract.Details
ReturnType<X>
as recommended in the Developer Guide. (Improves the API docs and supports comments)__legacy
return item fromSetup
function because it was unused.sessionTimeout
return from theSetup
function because it also seems unused.Before:
After: