Skip to content

Commit

Permalink
Improve security plugin return types (#101492) (#101657)
Browse files Browse the repository at this point in the history
* Add explicit security types

* Remove sessionTimeout, seems unused

* add comments

* Add comments and fix test since removing the unused APIs

* remove unused import

* wording cleanup

* Export some types that are part of the public API but not exported

* more improvements for api docs

* update security docs

* Update x-pack/plugins/security/public/nav_control/nav_control_service.tsx

Co-authored-by: Larry Gregory <lgregorydev@gmail.com>

* Update x-pack/plugins/security/public/nav_control/nav_control_service.tsx

Co-authored-by: Larry Gregory <lgregorydev@gmail.com>

* Update x-pack/plugins/security/public/plugin.tsx

Co-authored-by: Larry Gregory <lgregorydev@gmail.com>

* Update x-pack/plugins/security/public/plugin.tsx

Co-authored-by: Larry Gregory <lgregorydev@gmail.com>

* remove unneccessary readonly prefix

* Update all api docs

Co-authored-by: Larry Gregory <lgregorydev@gmail.com>
# Conflicts:
#	api_docs/data.json
#	api_docs/data_index_patterns.json
#	api_docs/data_search.json
#	api_docs/deprecations.mdx
#	api_docs/licensing.json
#	api_docs/lists.json
#	api_docs/triggers_actions_ui.json
#	api_docs/usage_collection.json
  • Loading branch information
stacey-gammon committed Jun 8, 2021
1 parent 1591f39 commit fba0dcc
Show file tree
Hide file tree
Showing 53 changed files with 6,807 additions and 3,707 deletions.
2 changes: 1 addition & 1 deletion api_docs/actions.json
Original file line number Diff line number Diff line change
Expand Up @@ -1054,7 +1054,7 @@
],
"source": {
"path": "x-pack/plugins/actions/server/builtin_action_types/pagerduty.ts",
"lineNumber": 121
"lineNumber": 129
},
"deprecated": false,
"initialIsOpen": false
Expand Down
4 changes: 2 additions & 2 deletions api_docs/apm.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
],
"source": {
"path": "x-pack/plugins/apm/public/plugin.ts",
"lineNumber": 45
"lineNumber": 47
},
"deprecated": false,
"lifecycle": "setup",
Expand All @@ -96,7 +96,7 @@
],
"source": {
"path": "x-pack/plugins/apm/public/plugin.ts",
"lineNumber": 47
"lineNumber": 49
},
"deprecated": false,
"lifecycle": "start",
Expand Down
Loading

0 comments on commit fba0dcc

Please sign in to comment.