Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Add ability to edit APM alerts #76316

Closed
bmorelli25 opened this issue Aug 31, 2020 · 6 comments · Fixed by #106598
Closed

[APM] Add ability to edit APM alerts #76316

bmorelli25 opened this issue Aug 31, 2020 · 6 comments · Fixed by #106598
Assignees
Labels

Comments

@bmorelli25
Copy link
Member

bmorelli25 commented Aug 31, 2020

Generic alerts, metrics alerts, and Uptime alerts can be edited directly in the Alerting and Actions menu of Kibana: Select edit to open the edit flyout panel.
Screen Shot 2020-08-31 at 11 10 44 AM

Alerts created from the APM app do not offer this option. The only workaround I can find is to delete the alert and manually recreate it. It'd be great to be able to edit APM alerts.
Screen Shot 2020-08-31 at 11 09 47 AM

@bmorelli25 bmorelli25 added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Aug 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@christophercutajar
Copy link

christophercutajar commented Nov 18, 2020

The drawback of deleting and re-creating an alert is that you'll have to get the message first from .kibana and then re-create the alert.

Another approach I used https://github.com/pmuellr/kbn-action tool to update the existing alert and avoid deleting it. You'll still need to get the alert id from .kibana and the update command is very easy to miss an " or have an extra "! It will be little cumbersome until the first one is done.

Hope this feature gets in very soon!

@arisonl
Copy link
Contributor

arisonl commented Feb 17, 2021

We have received user feedback (cc @mikeh-elastic), requesting to allow users to edit APM alerts. As stated in the description, APM alerts are the only ones that do not offer this functionality and there is no workaround at the moment, at least one that would be tolerable from a UX perspective. What is the path forward? (cc @cyrille-leclerc)

@sorenlouv
Copy link
Member

Thanks for the feedback all. I've moved this up in priority and I hope we can do that for 7.13.

@arisonl
Copy link
Contributor

arisonl commented Jul 5, 2021

@sqren @cyrille-leclerc noting the continuous user interest we are receiving for this functionality.

@sorenlouv
Copy link
Member

@arisonl thanks for the feedback. We'll prioritize for 7.15

@smith smith self-assigned this Jul 21, 2021
smith added a commit that referenced this issue Jul 27, 2021
By pulling out most of the things that depend on the URL into where we open the flyout and passing them in as metadata props, we can make it so editing rules while in Stack Management.

You cannot edit a rule's service name, transaction type, or environment once it has been created (#106786 has been created to allow editing of these other values), but all other values can be edited.

In order for useFetcher to work outside of the APM plugin, it has been changed to use useKibana instead of useApmContext for toast notifications. The notifications API from useKibana is slightly different and allows passing a react element instead of a mount point as the body.

Fixes #76316.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jul 27, 2021
By pulling out most of the things that depend on the URL into where we open the flyout and passing them in as metadata props, we can make it so editing rules while in Stack Management.

You cannot edit a rule's service name, transaction type, or environment once it has been created (elastic#106786 has been created to allow editing of these other values), but all other values can be edited.

In order for useFetcher to work outside of the APM plugin, it has been changed to use useKibana instead of useApmContext for toast notifications. The notifications API from useKibana is slightly different and allows passing a react element instead of a mount point as the body.

Fixes elastic#76316.
kibanamachine added a commit that referenced this issue Jul 27, 2021
By pulling out most of the things that depend on the URL into where we open the flyout and passing them in as metadata props, we can make it so editing rules while in Stack Management.

You cannot edit a rule's service name, transaction type, or environment once it has been created (#106786 has been created to allow editing of these other values), but all other values can be edited.

In order for useFetcher to work outside of the APM plugin, it has been changed to use useKibana instead of useApmContext for toast notifications. The notifications API from useKibana is slightly different and allows passing a react element instead of a mount point as the body.

Fixes #76316.

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
streamich pushed a commit to vadimkibana/kibana that referenced this issue Aug 8, 2021
By pulling out most of the things that depend on the URL into where we open the flyout and passing them in as metadata props, we can make it so editing rules while in Stack Management.

You cannot edit a rule's service name, transaction type, or environment once it has been created (elastic#106786 has been created to allow editing of these other values), but all other values can be edited.

In order for useFetcher to work outside of the APM plugin, it has been changed to use useKibana instead of useApmContext for toast notifications. The notifications API from useKibana is slightly different and allows passing a react element instead of a mount point as the body.

Fixes elastic#76316.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants