Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GS] CMD+click should open the result in a new tab #147710

Closed
afharo opened this issue Dec 16, 2022 · 2 comments · Fixed by #183762
Closed

[GS] CMD+click should open the result in a new tab #147710

afharo opened this issue Dec 16, 2022 · 2 comments · Fixed by #183762
Labels
Feature:Navigational Search Global search bar good first issue low hanging fruit Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@afharo
Copy link
Member

afharo commented Dec 16, 2022 •
edited
Loading

From #77663:

When Cmd+click on a result in the Global Search, it should open the result in a new tab instead of navigating to the result in the current tab.

We may want to fix this in application.navigateToApp, though so it applies to all Cmd+click across Kibana.

Related issue: elastic/eui#5408
@afharo afharo added good first issue low hanging fruit Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Navigational Search Global search bar labels Dec 16, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo mentioned this issue Dec 16, 2022
Closed
7 tasks
@afharo afharo added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Feb 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

This was referenced May 17, 2024
Merged
Closed
Closed
rshen91 added a commit that referenced this issue Jun 3, 2024
@rshen91
[Global Search] Fix cmd + click open in new tab for results (#183762)
03639a2 
## Summary

Closes #147710

This PR follows the pattern set up in
https://github.com/elastic/kibana/blob/main/x-pack/plugins/spaces/public/nav_control/components/spaces_menu.tsx#L164-L170
to allow the cmd click behavior to work for kibana global search. I'm
exploring contributing to the EUI repository in this
elastic/eui#7788 but that avenue may not be
fruitful. This implementation is already being used in spaces and can
immediately provide value for global search with this PR merge.
rohanxz pushed a commit to honeyn303/kibana that referenced this issue Jun 4, 2024
@rshen91 @rohanxz
[Global Search] Fix cmd + click open in new tab for results (elastic#…
440ff16 
…183762)

## Summary

Closes elastic#147710

This PR follows the pattern set up in
https://github.com/elastic/kibana/blob/main/x-pack/plugins/spaces/public/nav_control/components/spaces_menu.tsx#L164-L170
to allow the cmd click behavior to work for kibana global search. I'm
exploring contributing to the EUI repository in this
elastic/eui#7788 but that avenue may not be
fruitful. This implementation is already being used in spaces and can
immediately provide value for global search with this PR merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Navigational Search Global search bar good first issue low hanging fruit Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
2 participants
@afharo @elasticmachine