[EuiSelectableTemplateSitewide] Open in new tab for global search #7788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @rshen91 |
rshen91
added a commit
to elastic/kibana
that referenced
this pull request
Jun 3, 2024
## Summary Closes #147710 This PR follows the pattern set up in https://github.com/elastic/kibana/blob/main/x-pack/plugins/spaces/public/nav_control/components/spaces_menu.tsx#L164-L170 to allow the cmd click behavior to work for kibana global search. I'm exploring contributing to the EUI repository in this elastic/eui#7788 but that avenue may not be fruitful. This implementation is already being used in spaces and can immediately provide value for global search with this PR merge.
rohanxz
pushed a commit
to honeyn303/kibana
that referenced
this pull request
Jun 4, 2024
…183762) ## Summary Closes elastic#147710 This PR follows the pattern set up in https://github.com/elastic/kibana/blob/main/x-pack/plugins/spaces/public/nav_control/components/spaces_menu.tsx#L164-L170 to allow the cmd click behavior to work for kibana global search. I'm exploring contributing to the EUI repository in this elastic/eui#7788 but that avenue may not be fruitful. This implementation is already being used in spaces and can immediately provide value for global search with this PR merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes elastic/kibana#147710 and #7787
See elastic/kibana#183762 for attempt on the Kibana side of things 😅
QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@defaultif default values are missing) and playground toggles