sanity check coordinates before calculate the mean

elastic · Jul 1, 2020 · ffedc7f · ffedc7f
1 parent d7cb371
commit ffedc7f
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 2 deletions.
diff --git a/x-pack/plugins/apm/public/services/rest/observability.dashboard.test.ts b/x-pack/plugins/apm/public/services/rest/observability.dashboard.test.ts
@@ -117,5 +117,45 @@ describe('Observability dashboard data', () => {
         },
       });
     });
+    it('returns transaction stat as 0 when y is undefined', async () => {
+      callApmApiMock.mockImplementation(() =>
+        Promise.resolve({
+          serviceCount: 0,
+          transactionCoordinates: [{ x: 1 }, { x: 2 }, { x: 3 }],
+        })
+      );
+      const response = await fetchLandingPageData(
+        {
+          startTime: '1',
+          endTime: '2',
+          bucketSize: '3',
+        },
+        { theme }
+      );
+      expect(response).toEqual({
+        title: 'APM',
+        appLink: '/app/apm',
+        stats: {
+          services: {
+            type: 'number',
+            label: 'Services',
+            value: 0,
+          },
+          transactions: {
+            type: 'number',
+            label: 'Transactions',
+            value: 0,
+            color: '#6092c0',
+          },
+        },
+        series: {
+          transactions: {
+            label: 'Transactions',
+            coordinates: [{ x: 1 }, { x: 2 }, { x: 3 }],
+            color: '#6092c0',
+          },
+        },
+      });
+    });
   });
 });
diff --git a/x-pack/plugins/apm/public/services/rest/observability_dashboard.ts b/x-pack/plugins/apm/public/services/rest/observability_dashboard.ts
@@ -47,8 +47,11 @@ export const fetchLandingPageData = async (
           'xpack.apm.observabilityDashboard.stats.transactions',
           { defaultMessage: 'Transactions' }
         ),
-        value:
-          mean(transactionCoordinates.map((coordinates) => coordinates.y)) || 0,
+        value: !!transactionCoordinates.length
+          ? mean(
+              transactionCoordinates.map((coordinates) => coordinates.y || 0)
+            )
+          : 0,
         color: theme.euiColorVis1,
       },
     },