changing transaction count to transaction rate per second

elastic · Jun 30, 2020 · d7cb371 · d7cb371
1 parent 2fe0051
commit d7cb371
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/x-pack/plugins/apm/public/services/rest/observability.dashboard.test.ts b/x-pack/plugins/apm/public/services/rest/observability.dashboard.test.ts
@@ -60,7 +60,7 @@ describe('Observability dashboard data', () => {
           transactions: {
             type: 'number',
             label: 'Transactions',
-            value: 6,
+            value: 2,
             color: '#6092c0',
           },
         },

diff --git a/x-pack/plugins/apm/public/services/rest/observability_dashboard.ts b/x-pack/plugins/apm/public/services/rest/observability_dashboard.ts
@@ -5,7 +5,7 @@
  */
 
 import { i18n } from '@kbn/i18n';
-import { sum } from 'lodash';
+import mean from 'lodash.mean';
 // eslint-disable-next-line @kbn/eslint/no-restricted-paths
 import { FetchDataParams } from '../../../../observability/public/data_handler';
 import { ApmFetchDataResponse } from '../../../../observability/public/typings/fetch_data_response';
@@ -47,7 +47,8 @@ export const fetchLandingPageData = async (
           'xpack.apm.observabilityDashboard.stats.transactions',
           { defaultMessage: 'Transactions' }
         ),
-        value: sum(transactionCoordinates.map((coordinates) => coordinates.y)),
+        value:
+          mean(transactionCoordinates.map((coordinates) => coordinates.y)) || 0,
         color: theme.euiColorVis1,
       },
     },

diff --git a/x-pack/plugins/apm/server/lib/observability_dashboard/get_transaction_coordinates.ts b/x-pack/plugins/apm/server/lib/observability_dashboard/get_transaction_coordinates.ts
@@ -48,10 +48,12 @@ export async function getTransactionCoordinates({
     },
   });
 
+  const deltaAsMinutes = (end - start) / 1000 / 60;
+
   return (
     aggregations?.distribution.buckets.map((bucket) => ({
       x: bucket.key,
-      y: bucket.doc_count,
+      y: bucket.doc_count / deltaAsMinutes,
     })) || []
   );
 }