Convert source config view to new page template

elastic · Jun 17, 2021 · cfe6d65 · cfe6d65
1 parent 0fc182b
commit cfe6d65
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 17 deletions.
diff --git a/...rch/public/applications/workplace_search/views/settings/components/source_config.test.tsx b/...rch/public/applications/workplace_search/views/settings/components/source_config.test.tsx
@@ -16,7 +16,6 @@ import { shallow } from 'enzyme';
 
 import { EuiConfirmModal } from '@elastic/eui';
 
-import { Loading } from '../../../../shared/loading';
 import { SaveConfig } from '../../content_sources/components/add_source/save_config';
 
 import { SourceConfig } from './source_config';
@@ -41,16 +40,6 @@ describe('SourceConfig', () => {
     expect(wrapper.find(EuiConfirmModal)).toHaveLength(1);
   });
 
-  it('returns loading when loading', () => {
-    setMockValues({
-      sourceConfigData,
-      dataLoading: true,
-    });
-    const wrapper = shallow(<SourceConfig sourceIndex={1} />);
-
-    expect(wrapper.find(Loading)).toHaveLength(1);
-  });
-
   it('handles delete click', () => {
     const wrapper = shallow(<SourceConfig sourceIndex={1} />);
     const saveConfig = wrapper.find(SaveConfig);

diff --git a/...e_search/public/applications/workplace_search/views/settings/components/source_config.tsx b/...e_search/public/applications/workplace_search/views/settings/components/source_config.tsx
@@ -12,8 +12,8 @@ import { useActions, useValues } from 'kea';
 import { EuiConfirmModal } from '@elastic/eui';
 import { i18n } from '@kbn/i18n';
 
-import { Loading } from '../../../../shared/loading';
-import { REMOVE_BUTTON, CANCEL_BUTTON } from '../../../constants';
+import { WorkplaceSearchPageTemplate } from '../../../components/layout';
+import { NAV, REMOVE_BUTTON, CANCEL_BUTTON } from '../../../constants';
 import { SourceDataItem } from '../../../types';
 import { AddSourceHeader } from '../../content_sources/components/add_source/add_source_header';
 import { AddSourceLogic } from '../../content_sources/components/add_source/add_source_logic';
@@ -39,16 +39,17 @@ export const SourceConfig: React.FC<SourceConfigProps> = ({ sourceIndex }) => {
     getSourceConfigData(serviceType);
   }, []);
 
-  if (dataLoading) return <Loading />;
-
   const hideConfirmModal = () => setConfirmModalVisibility(false);
   const showConfirmModal = () => setConfirmModalVisibility(true);
   const saveUpdatedConfig = () => saveSourceConfig(true);
 
   const header = <AddSourceHeader name={name} serviceType={serviceType} categories={categories} />;
 
   return (
-    <>
+    <WorkplaceSearchPageTemplate
+      pageChrome={[NAV.SETTINGS, NAV.SETTINGS_SOURCE_PRIORITIZATION, name]}
+      isLoading={dataLoading}
+    >
       <SaveConfig
         name={name}
         configuration={configuration}
@@ -77,6 +78,6 @@ export const SourceConfig: React.FC<SourceConfigProps> = ({ sourceIndex }) => {
           )}
         </EuiConfirmModal>
       )}
-    </>
+    </WorkplaceSearchPageTemplate>
   );
 };