Convert Settings > Connectors to new page template

elastic · Jun 17, 2021 · 0fc182b · 0fc182b
1 parent cc36617
commit 0fc182b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 21 deletions.
diff --git a/...search/public/applications/workplace_search/views/settings/components/connectors.test.tsx b/...search/public/applications/workplace_search/views/settings/components/connectors.test.tsx
@@ -14,7 +14,6 @@ import React from 'react';
 
 import { shallow } from 'enzyme';
 
-import { Loading } from '../../../../shared/loading';
 import { LicenseCallout } from '../../../components/shared/license_callout';
 
 import { Connectors } from './connectors';
@@ -33,16 +32,6 @@ describe('Connectors', () => {
     expect(wrapper.find('[data-test-subj="ConnectorRow"]')).toHaveLength(configuredSources.length);
   });
 
-  it('returns loading when loading', () => {
-    setMockValues({
-      connectors: configuredSources,
-      dataLoading: true,
-    });
-    const wrapper = shallow(<Connectors />);
-
-    expect(wrapper.find(Loading)).toHaveLength(1);
-  });
-
   it('renders LicenseCallout for restricted items', () => {
     const wrapper = shallow(<Connectors />);
 

diff --git a/...rise_search/public/applications/workplace_search/views/settings/components/connectors.tsx b/...rise_search/public/applications/workplace_search/views/settings/components/connectors.tsx
@@ -19,12 +19,12 @@ import {
   EuiSpacer,
 } from '@elastic/eui';
 
-import { Loading } from '../../../../shared/loading';
 import { EuiButtonEmptyTo } from '../../../../shared/react_router_helpers';
+import { WorkplaceSearchPageTemplate } from '../../../components/layout';
 import { LicenseCallout } from '../../../components/shared/license_callout';
 import { SourceIcon } from '../../../components/shared/source_icon';
-import { ViewContentHeader } from '../../../components/shared/view_content_header';
 import {
+  NAV,
   CONFIGURE_BUTTON,
   CONNECTORS_HEADER_TITLE,
   CONNECTORS_HEADER_DESCRIPTION,
@@ -46,8 +46,6 @@ export const Connectors: React.FC = () => {
     initializeConnectors();
   }, []);
 
-  if (dataLoading) return <Loading />;
-
   const availableConnectors = reject(
     connectors,
     ({ serviceType }) => serviceType === CUSTOM_SERVICE_TYPE
@@ -125,12 +123,15 @@ export const Connectors: React.FC = () => {
   );
 
   return (
-    <>
-      <ViewContentHeader
-        title={CONNECTORS_HEADER_TITLE}
-        description={CONNECTORS_HEADER_DESCRIPTION}
-      />
+    <WorkplaceSearchPageTemplate
+      pageChrome={[NAV.SETTINGS, NAV.SETTINGS_SOURCE_PRIORITIZATION]}
+      pageHeader={{
+        pageTitle: CONNECTORS_HEADER_TITLE,
+        description: CONNECTORS_HEADER_DESCRIPTION,
+      }}
+      isLoading={dataLoading}
+    >
       {connectorsList}
-    </>
+    </WorkplaceSearchPageTemplate>
   );
 };