This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
Refactoring, context propagation, graceful stop #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove "throttle", use time.Ticker channel directly - simplify worker.flush by using context - create spans directly, rather than in a short lived goroutine which is waited upon:
Sending events should be fast enough that there's no need for parallelism, and the concurrency is complicating things.
Add "With" methods to Input directly, for simpler and more idiomatic code.
Previously, interrupt (Ctrl+C) would not be handled well. e.g. while running benchmarks, benchmarks would continue to run, and you would need to interrupt every individual benchmark. With these changes we abort all benchmarks upon interrupt, as they would no longer be useful for comparisons. Non-benchmark load generation is gracefully stopped, and stats gathered per usual without error.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
v1v
added a commit
to v1v/hey-apm
that referenced
this pull request
Dec 17, 2021
* upstream/main: (37 commits) Update to assume use of data streams (elastic#198) JJBB: disable periodic trigger (elastic#195) es: only count workload events (elastic#193) Use specific docker compose context (elastic#191) define failure threshould from average instead of max (elastic#190) update go agent version (elastic#189) Add destination service to spans (elastic#188) worker: reinstate Events{Generated,Sent,Indexed} (elastic#187) Remove types, conv, strcoll packages (elastic#185) agent/tracer cleanup (elastic#184) Stop storing derived metrics (elastic#183) Wait for active output events before proceeding (elastic#181) worker: send spans in a separate goroutine (elastic#180) benchmark: drop duplicate benchmark (elastic#179) Refactoring, context propagation, graceful stop (elastic#177) Keep self instrumentation (elastic#174) Disable apm-server instrumentation (elastic#173) Upgrade go version and dependencies (elastic#172) Allow configuring multiple worker instances (elastic#171) Adds a nil check before querying libbeat metrics. (elastic#169) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are various changes here, some of which are only tangentially related. The overall gist is:
Closes #160