added loadBalancerIP option to service

[holygrolli]

• Chart version not bumped (the versions are all bumped and released at the same time)
• README.md updated with any new values or changes
• Updated template tests in ${CHART}/tests/*.py

opened to address #257 feature request which I need in a project. The old #323 somehow got stale.

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[cla-checker-service]

💚 CLA has been signed

[jmlrt]

Hi @adulescentulus,
Thanks for your PR.
Can you sign the CLA: https://www.elastic.co/contributor-agreement

[jmlrt]

jenkins test this please

[holygrolli]

@jmlrt I signed the CLA about 8 hours ago and got a pdf. I don't know what's next. Is there a manual processing step left?

[jmlrt]

cla/check

[jmlrt]

@jmlrt I signed the CLA about 8 hours ago and got a pdf. I don't know what's next. Is there a manual processing step left?

CLA check is done automatically. However it seems you signed it with your personnal email while the git commit has been done with some corporate email.

Can you change your commit email to the one you used to sign CLA?

You should be able to do that with the following commands:

git commit --amend --author="John Doe <john@doe.org>"
git push --force-with-lease

[holygrolli]

@jmlrt thanks for the hint. I fixed my mail address and now CLA passes and I hope the CI as it did locally

[jmlrt]

jenkins test this please

[holygrolli]

sorry just merged from master and so needs rebuild, didn't expect someone to be awake
But I don't understand why the build failed. Local make test works

[jmlrt]

jenkins test this please

[holygrolli]

aaahh now I get it: between two functions there need to be two blank lines, not one like I did. I need to fix this, don't I?

[jmlrt]

aaahh now I get it: between two functions there need to be two blank lines, not one like I did. I need to fix this, don't I?

Oh yes sorry, I relaunched the test without checking logs.

Indeed our python lint test is using black and requires 2 new lines between each functions.

[holygrolli]

finally hope everything is good to go now.

but why did make test did not report anything locally?

[jmlrt]

but why did make test did not report anything locally?

python lint job is using make lint-python

[jmlrt]

jenkins test this please

[jmlrt]

LGTM, thanks for this PR 👍