Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

add loadBalancerIP field #323

Closed
wants to merge 2 commits into from
Closed

add loadBalancerIP field #323

wants to merge 2 commits into from

Conversation

Efrat19
Copy link

@Efrat19 Efrat19 commented Oct 12, 2019

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

opened to address #257 feature request
Cheers!

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jmlrt jmlrt added the enhancement New feature or request label Oct 17, 2019
@jmlrt
Copy link
Member

jmlrt commented Nov 21, 2019

jenkins test this please

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helm lint is failling with the following error:

[ERROR] templates/: template: elasticsearch/templates/service.yaml:33:14: executing "elasticsearch/templates/service.yaml" at <.Values.service.loadBalancerIP>: map has no entry for key "loadBalancerIP"

You should add an empty service.loadBalancerIP value in values.yml.

@jmlrt
Copy link
Member

jmlrt commented Jan 20, 2020

jenkins test this please

@jmlrt
Copy link
Member

jmlrt commented Mar 24, 2020

addressed by #539

@jmlrt jmlrt closed this Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants