Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

split some of the deployment and daemonset config to make things more… #448

Closed
wants to merge 1 commit into from

Conversation

pbecotte
Copy link
Contributor

… flexible

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Looking at #446 realized we may want to split daemonset/deployment config in some places. This is kind of a big change to the values file though, so not sure if theres a better way to transition. Consider this as a proposal :)

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@FedeBev
Copy link

FedeBev commented Jan 17, 2020

I agree with you: this is a big change. However I can't a better way to do that.

Thanks

@jmlrt jmlrt added the enhancement New feature or request label Jan 20, 2020
@jmlrt
Copy link
Member

jmlrt commented Jan 20, 2020

jenkins test this please

@mitchellmaler
Copy link

Can this PR be merged in? We are still having issues with the resources being the same on all pods even though the daemonset pods use much less compared to the deployment pod.

@jmlrt
Copy link
Member

jmlrt commented Apr 10, 2020

Hey @pbecotte,
Thanks for your PR, however, this is a breaking change and we'd like to ensure user with old values can still use the chart after splitting config, so I started a rework in #572, which should allow re-using old values if they are still used.

@jmlrt
Copy link
Member

jmlrt commented Apr 17, 2020

Closed by #572
Thanks for your work @pbecotte

@jmlrt jmlrt closed this Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants