Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[metricbeat] Different tolerations, nodeSelector and affinity for deployment and daemonset #446

Closed
FedeBev opened this issue Jan 14, 2020 · 2 comments · Fixed by #572
Closed
Assignees
Labels
enhancement New feature or request

Comments

@FedeBev
Copy link

FedeBev commented Jan 14, 2020

Describe the feature:
In my opinion would be great to have a different value option for tolerations, nodeSelector and affinity of daemonset and deployment.

An example of value.yaml could be the following:

daemonset:
  nodeSelector: {}

  tolerations:
    - operator: "Exists"

deployment:
  nodeSelector:
    my_key: "true"

  tolerations:
    - key: my_key
      value: "true"
      operator: Equal
      effect: NoExecute

Describe a specific use case for the feature:

In our case, for example, we have a node pool dedicated to elastic stack and we would like to keep all the pods on it, when possible. This is for billing reason and to prevent the infrastructure components load from disturbing customer applications

If PR are welcome I can deal with that

@mitchellmaler
Copy link

Just ran into this same issue. We have dedicated nodes that have specific resource requirements but the metricbeat deployment is deploying to those nodes.

@jmlrt
Copy link
Member

jmlrt commented Feb 3, 2020

Hi @FedeBev, we have #448 open for that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants