Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] New Templates section #5632

Merged
merged 6 commits into from
Mar 30, 2022
Merged

[Docs] New Templates section #5632

merged 6 commits into from
Mar 30, 2022

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Feb 11, 2022

Pushes #5625 to main

Technically all these changes were already approved in #5625 but I've removed the stubbed page for Layout / Page and so the only Page component page is under Templates / Page template.

Checklist

…5625)

* [Docs] Create new section for “Templates”
- Moves Page Template, SuperDatePicker, and Searchable Sitewide Template
- Stubs in placeholder page for in lower level page components
- Fixes routes
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5632/

# Conflicts:
#	scripts/a11y-testing.js
#	src-docs/src/views/page/page_example.js
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5632/

@cchaos cchaos changed the title [Feature] EuiPageTemplate updates [Docs] New Templates section Mar 29, 2022
@cchaos cchaos added skip-changelog documentation Issues or PRs that only affect documentation - will not need changelog entries labels Mar 29, 2022
@cchaos cchaos marked this pull request as ready for review March 29, 2022 19:59
@cchaos
Copy link
Contributor Author

cchaos commented Mar 29, 2022

Changing this to merge the new "Templates" doc section and opening up for review, even though it's mostly already been reviewed. 😄

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5632/

@cchaos
Copy link
Contributor Author

cchaos commented Mar 30, 2022

Merging in so that I can update my new PR and get something up as a WIP

@cchaos cchaos merged commit fe993d8 into main Mar 30, 2022
@cee-chen cee-chen deleted the feature/page_templates branch March 31, 2022 15:55
@cee-chen cee-chen restored the feature/page_templates branch March 31, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants