-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiPageTemplate Feature] [Docs] Create new section for “Templates” #5625
[EuiPageTemplate Feature] [Docs] Create new section for “Templates” #5625
Conversation
- Moves Page Template, SuperDatePicker, and Searchable Sitewide Template - Stubs in placeholder page for in lower level page components - Fixes routes
Preview documentation changes for this PR: https://eui.elastic.co/pr_5625/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
This new section makes total sense.
Tested in Firefox, Safari, and Chrome. Tested the links and (re)read the texts.
Just have a few suggestions.
src-docs/src/views/selectable/selectable_sitewide_template_example.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with Elizabet's edits
Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
Preview documentation changes for this PR: https://eui.elastic.co/pr_5625/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5625/ |
This is the first of many PR's to breakdown the work being done for EuiPageTemplate in #5454
Moves Page Template, SuperDatePicker, and Searchable Sitewide Template into a new section
Stubs in placeholder page for in lower level page components
And fixes routes associated with these new/old pages.
ChecklistNothing new was added, just shifting some docs pages and routes