[EuiPopover] Fix removeEventListener with mismatched capture flag #5437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per MDN: 'Removal of a capturing listener does not affect a non-capturing version of the same listener, and vice versa.'
cee-chen
force-pushed
the
eui-popover-memory-leak
branch
from
9368e1b to
993ecaa
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5437/ |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5437/ |
thompsongl
approved these changes
Dec 3, 2021
There was a problem hiding this comment.
Thanks, @constancecchen!
I did a quick quick JS memory trial to verify cleanup:
After a series of navigation to and away from the popover page:
- The current release continuously increased live memory and never recovered the gain
- The new/fixed version increased live memory but also recovered at each cycle
|
@thompsongl if you don't mind I'd actually love to see a screencap/video of how you did that! I fiddled a bit in the memory tab of Firefox but got confused 🙈 |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5437/ |
This was referenced Dec 3, 2021
1 task
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per MDN: 'Removal of a capturing listener does not affect a non-capturing version of the same listener, and vice versa.'
closes #5435
This is causing a memory leak for Kibana (elastic/kibana#120251), so we'll likely need to backport this to 7.16 and 8.0
Checklist