[EuiPopover] Fix removeEventListener with mismatched capture flag (#5437

) * Fix removeEventListener with mismatched capture flag Per MDN: 'Removal of a capturing listener does not affect a non-capturing version of the same listener, and vice versa.' * Add changelog entry
elastic · Dec 3, 2021 · 611a18f · 611a18f
1 parent 7715da3
commit 611a18f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 
 - Fixed scrollbars in `EuiRange` tick labels in Safari ([#5427](https://github.com/elastic/eui/pull/5427))
 - Fixed an `EuiOverlayMask` bug where it calls window.document on server side([#5422](https://github.com/elastic/eui/pull/5422))
+- Fixed unremoved event listener memory leak in `EuiPopover` ([#5436](https://github.com/elastic/eui/pull/5436))
 
 ## [`42.0.0`](https://github.com/elastic/eui/tree/v42.0.0)
 

diff --git a/src/components/popover/popover.tsx b/src/components/popover/popover.tsx
@@ -546,7 +546,7 @@ export class EuiPopover extends Component<Props, State> {
   }
 
   componentWillUnmount() {
-    window.removeEventListener('scroll', this.positionPopoverFixed);
+    window.removeEventListener('scroll', this.positionPopoverFixed, true);
     clearTimeout(this.respositionTimeout);
     clearTimeout(this.closingTransitionTimeout);
     cancelAnimationFrame(this.closingTransitionAnimationFrame!);