Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

95017 fix downsampling step #95054

Merged
merged 2 commits into from
Apr 5, 2023
Merged

95017 fix downsampling step #95054

merged 2 commits into from
Apr 5, 2023

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Apr 5, 2023

The manual downsampling example in our docs has an extra, unneeded and incorrect step, so this removes it.

Re-run your search query to view the aggregated time series data.
GET /sample-01*/_search

The re-run of GET /sample-01*/_search appears later in the page, after the user has run downsampling.

Closes #95017

@kilfoyle kilfoyle requested a review from abdonpijpelink April 5, 2023 13:51
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

Documentation preview:

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.8.0 labels Apr 5, 2023
@kilfoyle kilfoyle mentioned this pull request Apr 5, 2023
Closed
@kilfoyle kilfoyle added the Team:Docs Meta label for docs team label Apr 5, 2023
@elasticsearchmachine elasticsearchmachine removed the Team:Docs Meta label for docs team label Apr 5, 2023
@kilfoyle kilfoyle added Team:Docs Meta label for docs team :StorageEngine/TSDB You know, for Metrics >docs General docs changes labels Apr 5, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 5, 2023
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Apr 5, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

abdonpijpelink
abdonpijpelink approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilfoyle kilfoyle merged commit 9a673ad into elastic:main Apr 5, 2023
@kilfoyle kilfoyle mentioned this pull request Apr 5, 2023
Merged
kilfoyle added a commit to kilfoyle/elasticsearch that referenced this pull request Apr 5, 2023
@kilfoyle
95017 fix downsampling step (elastic#95054)
bb6eac6 
* Remove extra step in manual downsampling docs

* create -> view
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.7

elasticsearchmachine pushed a commit that referenced this pull request Apr 5, 2023
@kilfoyle
95017 fix downsampling step (#95054) (#95055)
d75f7f2 
* Remove extra step in manual downsampling docs

* create -> view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdonpijpelink abdonpijpelink abdonpijpelink approved these changes

Assignees
No one assigned
Labels
>docs General docs changes :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v8.7.1 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong step in documentation for downsampling
3 participants
@kilfoyle @elasticsearchmachine @abdonpijpelink