Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong step in documentation for downsampling #95017

Closed
andrei-gutierrez opened this issue Apr 4, 2023 · 5 comments · Fixed by #95054
Closed

Wrong step in documentation for downsampling #95017

andrei-gutierrez opened this issue Apr 4, 2023 · 5 comments · Fixed by #95054
Labels
>bug >docs General docs changes :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team

Comments

@andrei-gutierrez
Copy link

Elasticsearch Version

8.6.2

Installed Plugins

No response

Java Version

bundled

OS Version

any

Problem Description

Documentation manual is having a problem in a step
https://www.elastic.co/guide/en/elasticsearch/reference/8.7/downsampling-manual.html
"
Re-run your search query to view the aggregated time series data.
GET /sample-01*/_search
"

Steps to Reproduce

The search query is a search not an aggregation, the step is either wrong or is missplaced

Logs (if relevant)

No response

@andrei-gutierrez andrei-gutierrez added >bug needs:triage Requires assignment of a team area label labels Apr 4, 2023
@pxsalehi pxsalehi added :StorageEngine/TSDB You know, for Metrics and removed needs:triage Requires assignment of a team area label labels Apr 4, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 4, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@csoulios csoulios added the >docs General docs changes label Apr 4, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Apr 4, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@csoulios
Copy link
Contributor

csoulios commented Apr 4, 2023

@andrei-gutierrez thanks for reporting this. You are right, the query should be an agg query requesting the same aggs as in the original index. This is clear from the results shown below in the page.

@salvatore-campagna
Copy link
Contributor

I am re-assigning this to the docs team.

@salvatore-campagna salvatore-campagna added Team:Docs Meta label for docs team and removed Team:Docs Meta label for docs team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Apr 4, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Apr 4, 2023
@kilfoyle
Copy link
Contributor

kilfoyle commented Apr 5, 2023

Thanks all! I think that step was extraneous. Rerun of the GET /sample-01*/_search query appears later in the page after the downsampling is run. I've opened a PR to fix it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug >docs General docs changes :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants