Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Granting kibana_system reserved role access to all privileges to .internal.alerts* (#76624) #76635

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

spong
Copy link
Member

@spong spong commented Aug 18, 2021

Backports the following commits to 7.x:

…ernal.alerts* (elastic#76624)

**Parent ticket:** elastic/kibana#101016
**Related to:** elastic#72181

## Summary

Similar to the previous PR (elastic#72181), we'd like to add privileges to a new set of indices to the `kibana_system` role.

The reason for that is we need to have different naming schemes for alerts-as-data index aliases and backing indices pointing to these aliases, which in turn is needed to support backwards compatibility, migrations and reindexing in the future.

We didn't want to prefix the backing indices with `.kibana-`, so we're adding a new `.internal.alerts` prefix. Prefixing with `.kibana-` would make them system indices, which means they would not be supposed to be read by end users, which is not what we want.

`.internal` could become a universal prefix for hidden Kibana indices, but at this point I don't feel confident enough to generalise prematurely.
@spong spong added the backport label Aug 18, 2021
@elasticsearchmachine elasticsearchmachine added v7.15.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 18, 2021
@spong spong added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Aug 18, 2021
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticsearchmachine elasticsearchmachine merged commit 46529f0 into elastic:7.x Aug 18, 2021
@spong spong deleted the backport/7.x/pr-76624 branch August 18, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport external-contributor Pull request authored by a developer outside the Elasticsearch team v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants