Granting kibana_system reserved role access to "all" privileges to .internal.alerts* index #76624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banderror
added
>enhancement
:Security/Authorization
banderror
requested review from
kobelb,
dhurley14,
weltenwort and
marshallmain
|
Pinging @elastic/es-security (Team:Security) |
|
@elastic/kibana-security do any of you want to review this PR as well? |
kobelb
approved these changes
Aug 17, 2021
madirey
reviewed
Aug 17, 2021
| @@ -404,15 +405,20 @@ public static RoleDescriptor kibanaSystemRoleDescriptor(String name) { | |||
| RoleDescriptor.IndicesPrivileges.builder() | |||
| .indices(".fleet*") | |||
| .privileges("all").build(), | |||
| // Legacy "Alerts as data" index. Kibana user will create this index. | |||
| // Kibana user will read / write to these indices | |||
| // Legacy "Alerts as data" used in Security Solution. | |||
There was a problem hiding this comment.
Nit: "Alerts as data" indices used in Security Solution.
madirey
approved these changes
Aug 17, 2021
banderror
added
the
auto-backport
spong
pushed a commit
to spong/elasticsearch
that referenced
this pull request
Aug 18, 2021
…ernal.alerts* (elastic#76624) **Parent ticket:** elastic/kibana#101016 **Related to:** elastic#72181 ## Summary Similar to the previous PR (elastic#72181), we'd like to add privileges to a new set of indices to the `kibana_system` role. The reason for that is we need to have different naming schemes for alerts-as-data index aliases and backing indices pointing to these aliases, which in turn is needed to support backwards compatibility, migrations and reindexing in the future. We didn't want to prefix the backing indices with `.kibana-`, so we're adding a new `.internal.alerts` prefix. Prefixing with `.kibana-` would make them system indices, which means they would not be supposed to be read by end users, which is not what we want. `.internal` could become a universal prefix for hidden Kibana indices, but at this point I don't feel confident enough to generalise prematurely.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 18, 2021
…ernal.alerts* (#76624) (#76635) **Parent ticket:** elastic/kibana#101016 **Related to:** #72181 ## Summary Similar to the previous PR (#72181), we'd like to add privileges to a new set of indices to the `kibana_system` role. The reason for that is we need to have different naming schemes for alerts-as-data index aliases and backing indices pointing to these aliases, which in turn is needed to support backwards compatibility, migrations and reindexing in the future. We didn't want to prefix the backing indices with `.kibana-`, so we're adding a new `.internal.alerts` prefix. Prefixing with `.kibana-` would make them system indices, which means they would not be supposed to be read by end users, which is not what we want. `.internal` could become a universal prefix for hidden Kibana indices, but at this point I don't feel confident enough to generalise prematurely. Co-authored-by: Georgii Gorbachev <banderror@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent ticket: elastic/kibana#101016
Related to: #72181
Summary
Similar to the previous PR (#72181), we'd like to add privileges to a new set of indices to the
kibana_systemrole.The reason for that is we need to have different naming schemes for alerts-as-data index aliases and backing indices pointing to these aliases, which in turn is needed to support backwards compatibility, migrations and reindexing in the future.
We didn't want to prefix the backing indices with
.kibana-, so we're adding a new.internal.alertsprefix. Prefixing with.kibana-would make them system indices, which means they would not be supposed to be read by end users, which is not what we want..internalcould become a universal prefix for hidden Kibana indices, but at this point I don't feel confident enough to generalise prematurely.