-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] How to migrate to node roles from node attrs. Closes #65855 #71160
Conversation
Pinging @elastic/es-core-features (Team:Core/Features) |
Pinging @elastic/es-docs (Team:Docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @debadair
I think this is a good start for the guide. I've left a few comments.
We should elaborate on the motivations behind needing these steps, either inline or maybe in a new troubleshooting section?
I'm still working on summarising the scenarios and proposed solutions and will comment here or send them over a gdoc when finished
docs/reference/data-management/migrate-index-allocation-filters.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-management/migrate-index-allocation-filters.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-management/migrate-index-allocation-filters.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-management/migrate-index-allocation-filters.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-management/migrate-index-allocation-filters.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-management/migrate-index-allocation-filters.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-management/migrate-index-allocation-filters.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-management/migrate-index-allocation-filters.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-management/migrate-index-allocation-filters.asciidoc
Outdated
Show resolved
Hide resolved
Can we also include explicit settings and examples that require change?
This should be converted to include routing with
|
d5a8ad8
to
9999936
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @debadair
This is looking great!
I've left just a few more minor questions and suggestions.
docs/reference/data-management/migrate-index-allocation-filters.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-management/migrate-index-allocation-filters.asciidoc
Show resolved
Hide resolved
docs/reference/data-management/migrate-index-allocation-filters.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-management/migrate-index-allocation-filters.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-management/migrate-index-allocation-filters.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/data-management/migrate-index-allocation-filters.asciidoc
Show resolved
Hide resolved
…s.asciidoc Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (assuming the docs-checks need some work to get them passing?), thanks for iterating on this Deb
This will be greatly appreciated by our users!
When you add a data tier to an {ess} deployment, | ||
new nodes are automatically assigned to the tier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only true for the hot
tier (data_hot
node role). New indices are always allocated to the hot (or content) tier irrespective of the user adding the warm or cold tier. Shall we be more specific here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point I was trying to make was that when you add a tier to your deployment, nodes are configured with the corresponding role automatically. I tweaked the wording to make that clearer.
…5855 (elastic#71160) * [DOCS] Document how to migrate to node roles from node attrs. Closes elastic#65855 * [DOCS] Incorporated review comments * Update docs/reference/data-management/migrate-index-allocation-filters.asciidoc Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
…5855 (elastic#71160) * [DOCS] Document how to migrate to node roles from node attrs. Closes elastic#65855 * [DOCS] Incorporated review comments * Update docs/reference/data-management/migrate-index-allocation-filters.asciidoc Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
…5855 (elastic#71160) * [DOCS] Document how to migrate to node roles from node attrs. Closes elastic#65855 * [DOCS] Incorporated review comments * Update docs/reference/data-management/migrate-index-allocation-filters.asciidoc Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
…5855 (elastic#71160) * [DOCS] Document how to migrate to node roles from node attrs. Closes elastic#65855 * [DOCS] Incorporated review comments * Update docs/reference/data-management/migrate-index-allocation-filters.asciidoc Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
…5855 (elastic#71160) * [DOCS] Document how to migrate to node roles from node attrs. Closes elastic#65855 * [DOCS] Incorporated review comments * Update docs/reference/data-management/migrate-index-allocation-filters.asciidoc Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
…71160) (#72346) * [DOCS] Document how to migrate to node roles from node attrs. Closes #65855 * [DOCS] Incorporated review comments * Update docs/reference/data-management/migrate-index-allocation-filters.asciidoc Co-authored-by: Andrei Dan <andrei.dan@elastic.co> Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
…71160) (#72345) * [DOCS] Document how to migrate to node roles from node attrs. Closes #65855 * [DOCS] Incorporated review comments * Update docs/reference/data-management/migrate-index-allocation-filters.asciidoc Co-authored-by: Andrei Dan <andrei.dan@elastic.co> Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
…71160) (#72344) * [DOCS] Document how to migrate to node roles from node attrs. Closes #65855 * [DOCS] Incorporated review comments * Update docs/reference/data-management/migrate-index-allocation-filters.asciidoc Co-authored-by: Andrei Dan <andrei.dan@elastic.co> Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
…71160) (#72343) * [DOCS] Document how to migrate to node roles from node attrs. Closes #65855 * [DOCS] Incorporated review comments * Update docs/reference/data-management/migrate-index-allocation-filters.asciidoc Co-authored-by: Andrei Dan <andrei.dan@elastic.co> Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
…71160) (#72342) * [DOCS] Document how to migrate to node roles from node attrs. Closes #65855 * [DOCS] Incorporated review comments * Update docs/reference/data-management/migrate-index-allocation-filters.asciidoc Co-authored-by: Andrei Dan <andrei.dan@elastic.co> Co-authored-by: Andrei Dan <andrei.dan@elastic.co>
Closes #65855
Preview: https://elasticsearch_71160.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/migrate-index-allocation-filters.html
In addition to the basic steps outlined here:
Are there upgrade/order implications that need to be called out, other than you should complete the upgrade before modifying the node roles, policies, and templates?
What is necessary on cloud deployments wrt template changes? Do they need to remove the old default template?
Are there any interactions with autoscaling or restores that need to be called out?