update method setSource(byte[] source) #26561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe xContentType) In ElasticSearch 5.5,the method setSource(byte[]) from the type IndexRequestBuilder is deprecated,use the method setSource(byte[] source,XContentType xContentType).
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jiangzhuolin
changed the title
cbuescher
reviewed
Sep 9, 2017
docs/java-api/docs/index_.asciidoc
Outdated
| @@ -140,7 +140,7 @@ String json = "{" + | |||
| "}"; | |||
|
|
|||
| IndexResponse response = client.prepareIndex("twitter", "tweet") | |||
| .setSource(json) | |||
| .setSource(json,XContentType.JSON) | |||
There was a problem hiding this comment.
nit: Could you add a whitespace afther the comma for better readability?
There was a problem hiding this comment.
hi, @cbuescher I'm so sorry about my doc style,this is my first commit for elasticsearch. and shoud I create a new pull request again?
cbuescher
approved these changes
Sep 9, 2017
There was a problem hiding this comment.
@jiangzhuolin good catch, thanks for opening the PR. I left a tiny note about formatting, will merge the PR once you were able to change this.
add a whitespace after the comma for better readability.
|
@elasticmachine test this please |
cbuescher
pushed a commit
that referenced
this pull request
Sep 11, 2017
The method setSource(byte[]) from the type IndexRequestBuilder is deprecated, use the method setSource(byte[] source, XContentType xContentType). * add a whitespace after the comma add a whitespace after the comma for better readability.
cbuescher
pushed a commit
that referenced
this pull request
Sep 11, 2017
The method setSource(byte[]) from the type IndexRequestBuilder is deprecated, use the method setSource(byte[] source, XContentType xContentType). * add a whitespace after the comma add a whitespace after the comma for better readability.
cbuescher
pushed a commit
that referenced
this pull request
Sep 11, 2017
The method setSource(byte[]) from the type IndexRequestBuilder is deprecated, use the method setSource(byte[] source, XContentType xContentType). * add a whitespace after the comma add a whitespace after the comma for better readability.
cbuescher
pushed a commit
that referenced
this pull request
Sep 11, 2017
The method setSource(byte[]) from the type IndexRequestBuilder is deprecated, use the method setSource(byte[] source, XContentType xContentType).
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 12, 2017
…rflow * origin/master: (59 commits) Fix Lucene version of 5.6.1. Remove azure deprecated settings (elastic#26099) Handle the 5.6.0 release Allow plugins to validate cluster-state on join (elastic#26595) Remove index mapper dynamic settings (elastic#25734) update AWS SDK for ECS Task IAM support in discovery-ec2 (elastic#26479) Azure repository: Accelerate the listing of files (used in delete snapshot) (elastic#25710) Build: Remove norelease from forbidden patterns (elastic#26592) Fix reference to painless inside expression engine (elastic#26528) Build: Move javadoc linking to root build.gradle (elastic#26529) Test: Remove leftover static bwc test case (elastic#26584) Docs: Remove remaining references to file and native scripts (elastic#26580) Snapshot fallback should consider build.snapshot elastic#26496: Set the correct bwc version after backport to 6.x Fix the MapperFieldType.rangeQuery API. (elastic#26552) Deduplicate `_field_names`. (elastic#26550) [Docs] Update method setSource(byte[] source) (elastic#26561) [Docs] Fix typo in javadocs (elastic#26556) Allow multiple digits in Vagrant 2.x minor versions Support Vagrant 2.x ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pe xContentType)
In ElasticSearch 5.5,the method setSource(byte[]) from the type IndexRequestBuilder is deprecated,use the method setSource(byte[] source,XContentType xContentType).