Fix the MapperFieldType.rangeQuery API. #26552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RangeQueryBuilder needs to perform too many `instanceof` checks in order to check for `date` or `range` fields in order to know what it should do with the shape relation, time zone and date format. This commit adds those 3 parameters to the `rangeQuery` factory method so that those instanceof checks are not necessary anymore.
jpountz
added
:Search Foundations/Mapping
jpountz
added a commit
that referenced
this pull request
Sep 11, 2017
RangeQueryBuilder needs to perform too many `instanceof` checks in order to check for `date` or `range` fields in order to know what it should do with the shape relation, time zone and date format. This commit adds those 3 parameters to the `rangeQuery` factory method so that those instanceof checks are not necessary anymore.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 12, 2017
…rflow * origin/master: (59 commits) Fix Lucene version of 5.6.1. Remove azure deprecated settings (elastic#26099) Handle the 5.6.0 release Allow plugins to validate cluster-state on join (elastic#26595) Remove index mapper dynamic settings (elastic#25734) update AWS SDK for ECS Task IAM support in discovery-ec2 (elastic#26479) Azure repository: Accelerate the listing of files (used in delete snapshot) (elastic#25710) Build: Remove norelease from forbidden patterns (elastic#26592) Fix reference to painless inside expression engine (elastic#26528) Build: Move javadoc linking to root build.gradle (elastic#26529) Test: Remove leftover static bwc test case (elastic#26584) Docs: Remove remaining references to file and native scripts (elastic#26580) Snapshot fallback should consider build.snapshot elastic#26496: Set the correct bwc version after backport to 6.x Fix the MapperFieldType.rangeQuery API. (elastic#26552) Deduplicate `_field_names`. (elastic#26550) [Docs] Update method setSource(byte[] source) (elastic#26561) [Docs] Fix typo in javadocs (elastic#26556) Allow multiple digits in Vagrant 2.x minor versions Support Vagrant 2.x ...
cbuescher
pushed a commit
that referenced
this pull request
Dec 18, 2017
#27878) The mixed cluster test are currently failing the range/10_basic rest tests because they are testing the use of range fields in query_string queries in a mixed cluster with 5.6 nodes. According to #26552 this feature was only merged to version 6.1.0. This change moves the test causing these failures to their own test section that can be skipped for versions before 6.1.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RangeQueryBuilder needs to perform too many
instanceofchecks in order tocheck for
dateorrangefields in order to know what it should do with theshape relation, time zone and date format.
This commit adds those 3 parameters to the
rangeQueryfactory method so thatthose instanceof checks are not necessary anymore.