Clean up snapshots where possible after each REST test #20489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
>test
|
LGTM |
javanna
reviewed
Sep 15, 2016
| } | ||
| logger.debug("wiping snapshot repository [{}]", repoName); | ||
| adminClient().performRequest("DELETE", "_snapshot/" + repoName); | ||
| } |
There was a problem hiding this comment.
thanks @nik9000 ! @elastic/es-clients is this ok? I guess all the client runners will have to be changed accordingly.
There was a problem hiding this comment.
I don't think they'll start failing without this right away, but they should probably pick it up eventually. I'll wait to merge this until we get a response.
There was a problem hiding this comment.
Fine with me :) I'm already wiping the repository itself after each test, so this shouldn't have much effect (I don't think).
The only repository we can be sure is safe to clean is `fs` so we clean any snapshots in those repositories after each test. Other repositories like url and azure tend to throw exceptions rather than let us fetch their contents during the REST test. So we clean what we can.... Closes elastic#18159
nik9000
force-pushed
the
clean_snapshots
branch
from
97bb5fa
to
d0be96d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only repository we can be sure is safe to clean is
fsso we cleanany snapshots in those repositories after each test. Other repositories
like url and azure tend to throw exceptions rather than let us fetch
their contents during the REST test. So we clean what we can....
Closes #18159