-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rest tests need to clean up snapshots #18159
Labels
Comments
I've started poking at this but not really got all the way to fixing it. I'll come back to it in a few days if no one else wants it first. |
@nik9000 this is still valid right? |
I think so. I just forgot about it. I can pick it up again soon though. |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this issue
Sep 15, 2016
The only repository we can be sure is safe to clean is `fs` so we clean any snapshots in those repositories after each test. Other repositories like url and azure tend to throw exceptions rather than let us fetch their contents during the REST test. So we clean what we can.... Closes elastic#18159
nik9000
added a commit
that referenced
this issue
Sep 15, 2016
The only repository we can be sure is safe to clean is `fs` so we clean any snapshots in those repositories after each test. Other repositories like url and azure tend to throw exceptions rather than let us fetch their contents during the REST test. So we clean what we can.... Closes #18159
nik9000
added a commit
that referenced
this issue
Sep 15, 2016
The only repository we can be sure is safe to clean is `fs` so we clean any snapshots in those repositories after each test. Other repositories like url and azure tend to throw exceptions rather than let us fetch their contents during the REST test. So we clean what we can.... Closes #18159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Elasticsearch version:
5.0.0
Description of the problem including expected versus actual behavior:
Right now the rest tests wipe snapshots by deleting all of the repositories. This doesn't really work because if you recreate a repository with the same name it'll still contain the snapshots. The tests should actually wipe all of the snapshots.
The text was updated successfully, but these errors were encountered: