Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest tests need to clean up snapshots #18159

Closed
nik9000 opened this issue May 5, 2016 · 3 comments
Closed

Rest tests need to clean up snapshots #18159

nik9000 opened this issue May 5, 2016 · 3 comments
Assignees
Labels
>test Issues or PRs that are addressing/adding tests v5.0.0-beta1

Comments

@nik9000
Copy link
Member

nik9000 commented May 5, 2016

Elasticsearch version:
5.0.0

Description of the problem including expected versus actual behavior:
Right now the rest tests wipe snapshots by deleting all of the repositories. This doesn't really work because if you recreate a repository with the same name it'll still contain the snapshots. The tests should actually wipe all of the snapshots.

@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests v5.0.0-alpha3 labels May 5, 2016
@nik9000
Copy link
Member Author

nik9000 commented May 5, 2016

I've started poking at this but not really got all the way to fixing it. I'll come back to it in a few days if no one else wants it first.

@javanna
Copy link
Member

javanna commented Sep 14, 2016

@nik9000 this is still valid right?

@nik9000
Copy link
Member Author

nik9000 commented Sep 14, 2016

I think so. I just forgot about it. I can pick it up again soon though.

@nik9000 nik9000 self-assigned this Sep 14, 2016
nik9000 added a commit to nik9000/elasticsearch that referenced this issue Sep 15, 2016
The only repository we can be sure is safe to clean is `fs` so we clean
any snapshots in those repositories after each test. Other repositories
like url and azure tend to throw exceptions rather than let us fetch
their contents during the REST test. So we clean what we can....

Closes elastic#18159
nik9000 added a commit that referenced this issue Sep 15, 2016
The only repository we can be sure is safe to clean is `fs` so we clean
any snapshots in those repositories after each test. Other repositories
like url and azure tend to throw exceptions rather than let us fetch
their contents during the REST test. So we clean what we can....

Closes #18159
nik9000 added a commit that referenced this issue Sep 15, 2016
The only repository we can be sure is safe to clean is `fs` so we clean
any snapshots in those repositories after each test. Other repositories
like url and azure tend to throw exceptions rather than let us fetch
their contents during the REST test. So we clean what we can....

Closes #18159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>test Issues or PRs that are addressing/adding tests v5.0.0-beta1
Projects
None yet
Development

No branches or pull requests

3 participants