Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] tests code cleanup #618

Merged
merged 4 commits into from
Aug 21, 2017
Merged

[TEST] tests code cleanup #618

merged 4 commits into from
Aug 21, 2017

Commits on Aug 20, 2017

  1. [TEST] use ::class instead of classname string 

    Reason - when the class is renamed or removed, it will be detected much faster.
It helps with the static analysis of the code (also used by IDEs)
    @mhujer
    mhujer committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    ccb3269 View commit details
    Browse the repository at this point in the history

  2. [TEST] use assertSame() instead of assertEquals() 

    assertEquals() means ==
assertSame() is ===

Can cause tests not detecting issues, because different instances of
same class with same data are equal, but not the same.
    @mhujer
    mhujer committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    4f0bb84 View commit details
    Browse the repository at this point in the history

  3. [TEST] convert array() to [] syntax

    @mhujer
    mhujer committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    0e9c99f View commit details
    Browse the repository at this point in the history

  4. [TEST] $this->assert* should be used 

    See
sebastianbergmann/phpunit#1914 (comment)
    @mhujer
    mhujer committed Aug 20, 2017
    Configuration menu
    Copy the full SHA
    5875d52 View commit details
    Browse the repository at this point in the history