[TEST] tests code cleanup #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason - when the class is renamed or removed, it will be detected much faster. It helps with the static analysis of the code (also used by IDEs)
assertEquals() means == assertSame() is === Can cause tests not detecting issues, because different instances of same class with same data are equal, but not the same.
mhujer
force-pushed
the
mh-tests-improvements
branch
from
06debd9
to
5875d52
Compare
|
@polyfractal I've rebased this and it is ready for review. |
|
LGTM, thanks for these :) Looking through the affected code, it reminds me that there are still a few unit tests that still rely on an externally running cluster (e.g. I'll open an issue so that these don't continue being forgotten about :) |
p365labs
pushed a commit
to p365labs/elasticsearch-php
that referenced
this pull request
Sep 10, 2017
* [TEST] use ::class instead of classname string Reason - when the class is renamed or removed, it will be detected much faster. It helps with the static analysis of the code (also used by IDEs) * [TEST] use assertSame() instead of assertEquals() assertEquals() means == assertSame() is === Can cause tests not detecting issues, because different instances of same class with same data are equal, but not the same. * [TEST] convert array() to [] syntax * [TEST] $this->assert* should be used See sebastianbergmann/phpunit#1914 (comment)
p365labs
pushed a commit
to p365labs/elasticsearch-php
that referenced
this pull request
Sep 10, 2017
* [TEST] use ::class instead of classname string Reason - when the class is renamed or removed, it will be detected much faster. It helps with the static analysis of the code (also used by IDEs) * [TEST] use assertSame() instead of assertEquals() assertEquals() means == assertSame() is === Can cause tests not detecting issues, because different instances of same class with same data are equal, but not the same. * [TEST] convert array() to [] syntax * [TEST] $this->assert* should be used See sebastianbergmann/phpunit#1914 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #612 (should be merged first)merge 612Reasoning for each change is included in the individual commit messages.