Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event.id -> http.request.id in formatHttpRequest #76

Closed
trentm opened this issue Mar 30, 2021 · 0 comments · Fixed by #163
Closed

event.id -> http.request.id in formatHttpRequest #76

trentm opened this issue Mar 30, 2021 · 0 comments · Fixed by #163
Assignees
@trentm
Labels
agent-nodejs Make available for APM Agents project planning.

Comments

@trentm
Copy link
Member

trentm commented Mar 30, 2021

ECS 1.9.0 formalizes http.request.id: https://github.com/elastic/ecs/releases/tag/v1.9.0

Currently formatHttpRequest will map req.id to event.id. That isn't documented or in the tests. Judgement call if that mandates a breaking change to remove.
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Mar 30, 2021
@diegoneemu diegoneemu mentioned this issue Sep 30, 2022
Closed
@trentm trentm self-assigned this Oct 26, 2023
trentm added a commit that referenced this issue Oct 26, 2023
@trentm
feat: add 'http.request.id' field, @elastic/ecs-helpers@2.1.0, bump e…
b33898b 
…cs.version to 8.10.0

Closes: #133
Closes: #76
This was referenced Oct 26, 2023
Merged
Closed
trentm added a commit that referenced this issue Oct 27, 2023
@trentm
feat: add 'http.request.id' field, @elastic/ecs-helpers@2.1.0, bump e…
7c82a8d 
…cs.version to 8.10.0 (#163)

Closes: #133
Closes: #76
@trentm trentm mentioned this issue Oct 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentm trentm

Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
1 participant
@trentm