Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS version update #133

Closed
faljabi opened this issue Jan 16, 2023 · 3 comments · Fixed by #163
Closed

ECS version update #133

faljabi opened this issue Jan 16, 2023 · 3 comments · Fixed by #163
Assignees
Labels
agent-nodejs Make available for APM Agents project planning. community

Comments

@faljabi
Copy link

faljabi commented Jan 16, 2023

When logging via winston I noticed that the ecs version is 1.6.0. Is this maintained to catch up with ECS versions 8.x?

@github-actions github-actions bot added agent-nodejs Make available for APM Agents project planning. community triage labels Jan 16, 2023
@rom1vtle
Copy link

rom1vtle commented Aug 3, 2023

Today, do have a solution to resolve this problem ? or alternative code ?
I got the same probleme

@trentm
Copy link
Member

trentm commented Oct 3, 2023

Note that (per https://www.elastic.co/guide/en/ecs/current/ecs-ecs.html#field-ecs-version) the ecs.version field shouldn't itself be a cause of compatibility concerns. Are there particular compatibility issues with some fields that you are hitting?

The ECS logging formatters from this repo don't touch on that many fields in ECS, so it is possible (even likely) that there won't be any breakage when moving the ecs.version value forward.

I'll keep this issue open until we've updating the ecs.version value emitted by these loggers.

(Note to self: I'll need to work forward through the ECS versions starting from https://github.com/elastic/ecs/blob/main/CHANGELOG.md#160 to see if there are any adjustments needed.)

@trentm trentm changed the title ECS version question ECS version update Oct 3, 2023
@trentm trentm removed the triage label Oct 3, 2023
@trentm trentm self-assigned this Oct 26, 2023
@trentm
Copy link
Member

trentm commented Oct 26, 2023

The relevant ECS field namespaces for these ecs-logging-nodejs libs are:

working through the ECS changelog

Pulling out all possibly relevant references in https://github.com/elastic/ecs/blob/main/CHANGELOG.md from 1.6.0 to the current latest (8.10.0):

1.7.0

  • http.[request|response].mime_type #944
  • Added the field .subdomain under client, destination, server, source and url, to match its presence at dns.question.subdomain. #981

1.8.0

Added os.type. #1111

1.9.0

Added http.request.id. #1208

8.0.0

  • Remove deprecation notice on http.request.method. #1443

8.7.0

  • description for host.name definition updated to encourage use of FDQN #2122

summary

  • log - No relevant changes.
  • ecs - No changes.
    • We'll bump ecs.version to "8.10.0".
  • tracing - No changes.
  • error - No changes.
  • client - No relevant changes.
  • http
    • http.[request|response].mime_type added in 1.7.0, but not considering
      adding this. It must be determined from response content, not a header.
    • http.request.id added in 1.9.0. Consider adding a possible req.id
      to http.request.id instead of to event.id. Note that req.id is not
      part of the http.IncomingMessage
      interface. Need to trawl through the various web frameworks to come up
      with any typical interface for a request id.
    • http.request.method guidance was changed in 8.0.0 to retain the origin casing.
  • url - No relevant changes.
  • event? Just event.dataset. - No change.
  • host? Only for host.hostname used for Pino. - No change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning. community
Projects
None yet
3 participants