Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker.io/library/golang Docker tag to v1.20.2 #6497

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Update docker.io/library/golang Docker tag to v1.20.2 #6497

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f11583
Update docker.io/library/golang Docker tag to v1.20.2
renovate[bot] Mar 8, 2023
530f8d9
comment
thbkrkr Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Docker image used for continuous integration
FROM docker.io/library/golang:1.19.5
FROM docker.io/library/golang:1.20.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it has been reverted on purpose: #6420
I tried to run make lint on a locally built CI image but it's failing with:

GOGC=50 golangci-lint run --verbose
INFO [config_reader] Config search paths: [./ /go/src/github.com/elastic/cloud-on-k8s /go/src/github.com/elastic /go/src/github.com /go/src /go / /root]
INFO [config_reader] Used config file .golangci.yml
INFO [lintersdb] Active 40 linters: [asciicheck bodyclose deadcode dogsled durationcheck errcheck errorlint exhaustive exportloopref forcetypeassert gocritic goheader goimports goprintffuncname gosec gosimple govet importas ineffassign makezero misspell nakedret nestif nilerr noctx nolintlint prealloc predeclared revive staticcheck structcheck thelper tparallel typecheck unconvert unparam unused varcheck wastedassign whitespace]
INFO [loader] Go packages loading at mode 575 (name|types_sizes|compiled_files|deps|exports_file|files|imports) took 3m16.073783471s
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 174.117366ms
INFO [linters context] importas settings found, but no aliases listed. List aliases under alias: key.
make: *** [Makefile:184: lint] Killed

Not sure what's going on, should we create an issue and add a comment to explain to the reviewers why we should not update the image here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have at least left a comment. The goal was and still is to get rid of this image (Jenkins ci docker image).
We should soon be able to delete it and replace it with the bk agent image to avoid maintaining two images that are almost similar.


ENV GOLANGCILINT_VERSION=1.48.0
ENV SHELLCHECK_VERSION=0.8.0
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the operator binary
FROM --platform=$TARGETPLATFORM docker.io/library/golang:1.20.1 as builder
FROM --platform=$TARGETPLATFORM docker.io/library/golang:1.20.2 as builder

ARG TARGETPLATFORM
ARG BUILDPLATFORM
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.ubi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the operator binary
FROM --platform=$TARGETPLATFORM docker.io/library/golang:1.20.1 as builder
FROM --platform=$TARGETPLATFORM docker.io/library/golang:1.20.2 as builder

ARG TARGETPLATFORM
ARG BUILDPLATFORM
Expand Down
2 changes: 1 addition & 1 deletion hack/manifest-gen/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM docker.io/library/golang:1.20.1 as builder
FROM docker.io/library/golang:1.20.2 as builder
ADD . /manifest-gen
WORKDIR /manifest-gen
ENV GO111MODULE=on CGO_ENABLED=0 GOOS=linux
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Docker image for the E2E tests runner
FROM --platform=$TARGETPLATFORM docker.io/library/golang:1.20.1
FROM --platform=$TARGETPLATFORM docker.io/library/golang:1.20.2

ARG TARGETPLATFORM
ARG BUILDPLATFORM
Expand Down