-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker.io/library/golang Docker tag to v1.20.2 #6497
Conversation
@elasticmachine run elasticsearch-ci/docs |
.ci/Dockerfile
Outdated
@@ -1,5 +1,5 @@ | |||
# Docker image used for continuous integration | |||
FROM docker.io/library/golang:1.19.5 | |||
FROM docker.io/library/golang:1.20.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it has been reverted on purpose: #6420
I tried to run make lint
on a locally built CI image but it's failing with:
GOGC=50 golangci-lint run --verbose
INFO [config_reader] Config search paths: [./ /go/src/github.com/elastic/cloud-on-k8s /go/src/github.com/elastic /go/src/github.com /go/src /go / /root]
INFO [config_reader] Used config file .golangci.yml
INFO [lintersdb] Active 40 linters: [asciicheck bodyclose deadcode dogsled durationcheck errcheck errorlint exhaustive exportloopref forcetypeassert gocritic goheader goimports goprintffuncname gosec gosimple govet importas ineffassign makezero misspell nakedret nestif nilerr noctx nolintlint prealloc predeclared revive staticcheck structcheck thelper tparallel typecheck unconvert unparam unused varcheck wastedassign whitespace]
INFO [loader] Go packages loading at mode 575 (name|types_sizes|compiled_files|deps|exports_file|files|imports) took 3m16.073783471s
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 174.117366ms
INFO [linters context] importas settings found, but no aliases listed. List aliases under alias: key.
make: *** [Makefile:184: lint] Killed
Not sure what's going on, should we create an issue and add a comment to explain to the reviewers why we should not update the image here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have at least left a comment. The goal was and still is to get rid of this image (Jenkins ci docker image).
We should soon be able to delete it and replace it with the bk agent image to avoid maintaining two images that are almost similar.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
@elasticmachine run elasticsearch-ci/docs |
This PR contains the following updates:
1.20.1
->1.20.2
1.20.1
->1.20.2
1.19.5
->1.20.2
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.