-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump go version to 1.23 #42705
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
I've just updated this PR with the relevant changes to use the golang-crossbuild in ARM64 for ARM64. It requires further changes in:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you everyone for pushing this through!
There were a few CI metricbeat module related CI errors but to me they looked unrelated to this PR, I clicked retry anyway to see if they are transient.
Thanks for pushing through this @v1v and @kruskall LGTM! I noticed an earlier failure for x-pack/osquerybeat which seems to have passed with the latest CI run which made me investigate a bit more; turns out that contrary to every other beat, we don't have a dedicated linux/arm64 packaging step for Going forwards we probably want to file a ticket and implement this too, so that building arm64 for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving changes to packetbeat/* and auditbeat/*
* feat: bump go version to 1.23 * Update CHANGELOG.next.asciidoc * Update packaging.sh * Update packaging.sh * use the aarch image instead of the alias * we don't use qemu on ARM64 * fix packaging --------- Co-authored-by: Julien Lind <julien.lind@elastic.co> Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit eafca95) # Conflicts: # libbeat/docs/version.asciidoc
* feat: bump go version to 1.23 * Update CHANGELOG.next.asciidoc * Update packaging.sh * Update packaging.sh * use the aarch image instead of the alias * we don't use qemu on ARM64 * fix packaging --------- Co-authored-by: Julien Lind <julien.lind@elastic.co> Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit eafca95) # Conflicts: # libbeat/docs/version.asciidoc
* feat: bump go version to 1.23 * Update CHANGELOG.next.asciidoc * Update packaging.sh * Update packaging.sh * use the aarch image instead of the alias * we don't use qemu on ARM64 * fix packaging --------- Co-authored-by: Julien Lind <julien.lind@elastic.co> Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit eafca95) # Conflicts: # libbeat/docs/version.asciidoc
* feat: bump go version to 1.23 * Update CHANGELOG.next.asciidoc * Update packaging.sh * Update packaging.sh * use the aarch image instead of the alias * we don't use qemu on ARM64 * fix packaging --------- Co-authored-by: Julien Lind <julien.lind@elastic.co> Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit eafca95) # Conflicts: # libbeat/docs/version.asciidoc
* feat: bump go version to 1.23 * Update CHANGELOG.next.asciidoc * Update packaging.sh * Update packaging.sh * use the aarch image instead of the alias * we don't use qemu on ARM64 * fix packaging --------- Co-authored-by: Julien Lind <julien.lind@elastic.co> Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit eafca95)
See #43019 is now the implementation.
I might say something a bit different and in my view, we might to revisit what's implemented and create a table or something that can allow us to know what stages run and when. Back in the day, I used https://github.com/elastic/beats/blob/7.17/.ci/scripts/generate_build_table.py to create that table by reading all the |
Proposed commit message
go 1.24 has been released and 1.22 is EOL
bump to a supported version of go
(there might be an argument to bump to 1.24 to help with fips compliance but I'll open a followup PR for that)
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs