Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump go version to 1.23 #42705

Merged
merged 14 commits into from
Mar 4, 2025
Merged

feat: bump go version to 1.23 #42705

merged 14 commits into from
Mar 4, 2025

Conversation

kruskall
Copy link
Member

Proposed commit message

go 1.24 has been released and 1.22 is EOL

bump to a supported version of go

(there might be an argument to bump to 1.24 to help with fips compliance but I'll open a followup PR for that)

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@kruskall kruskall requested review from a team as code owners February 14, 2025 00:28
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 14, 2025
Copy link
Contributor

mergify bot commented Feb 14, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Feb 14, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 14, 2025
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Feb 14, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@Kavindu-Dodan Kavindu-Dodan self-requested a review February 14, 2025 21:45
@cmacknz cmacknz added the backport-8.x Automated backport to the 8.x branch with mergify label Feb 14, 2025
@v1v
Copy link
Member

v1v commented Mar 3, 2025

I've just updated this PR with the relevant changes to use the golang-crossbuild in ARM64 for ARM64. It requires further changes in:

  • .buildkite/x-pack/pipeline.xpack.dockerlogbeat.yml - unitTest step uses golang-corssbuild, so it requires the qem thing.
  • .buildkite/metricbeat/pipeline.yml - crosscompiles step uses golang-crossbuild, so it requires the qemu thing

@dliappis dliappis self-requested a review March 4, 2025 07:58
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you everyone for pushing this through!

There were a few CI metricbeat module related CI errors but to me they looked unrelated to this PR, I clicked retry anyway to see if they are transient.

@dliappis
Copy link
Contributor

dliappis commented Mar 4, 2025

Thanks for pushing through this @v1v and @kruskall LGTM!

I noticed an earlier failure for x-pack/osquerybeat which seems to have passed with the latest CI run which made me investigate a bit more; turns out that contrary to every other beat, we don't have a dedicated linux/arm64 packaging step for x-pack/osquerybeat either in DRA on in the PR packaging steps.

Going forwards we probably want to file a ticket and implement this too, so that building arm64 for x-pack/osquerybeat is done without qemu emulation but inside a dedicated worker too (as done for every other beat).

@kruskall kruskall enabled auto-merge (squash) March 4, 2025 19:37
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changes to packetbeat/* and auditbeat/*

@kruskall kruskall merged commit eafca95 into elastic:main Mar 4, 2025
152 checks passed
@kruskall kruskall deleted the feat/bump-1.23 branch March 4, 2025 20:06
mergify bot pushed a commit that referenced this pull request Mar 4, 2025
* feat: bump go version to 1.23

* Update CHANGELOG.next.asciidoc

* Update packaging.sh

* Update packaging.sh

* use the aarch image instead of the alias

* we don't use qemu on ARM64

* fix packaging

---------

Co-authored-by: Julien Lind <julien.lind@elastic.co>
Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com>
(cherry picked from commit eafca95)

# Conflicts:
#	libbeat/docs/version.asciidoc
mergify bot pushed a commit that referenced this pull request Mar 4, 2025
* feat: bump go version to 1.23

* Update CHANGELOG.next.asciidoc

* Update packaging.sh

* Update packaging.sh

* use the aarch image instead of the alias

* we don't use qemu on ARM64

* fix packaging

---------

Co-authored-by: Julien Lind <julien.lind@elastic.co>
Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com>
(cherry picked from commit eafca95)

# Conflicts:
#	libbeat/docs/version.asciidoc
mergify bot pushed a commit that referenced this pull request Mar 4, 2025
* feat: bump go version to 1.23

* Update CHANGELOG.next.asciidoc

* Update packaging.sh

* Update packaging.sh

* use the aarch image instead of the alias

* we don't use qemu on ARM64

* fix packaging

---------

Co-authored-by: Julien Lind <julien.lind@elastic.co>
Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com>
(cherry picked from commit eafca95)

# Conflicts:
#	libbeat/docs/version.asciidoc
mergify bot pushed a commit that referenced this pull request Mar 4, 2025
* feat: bump go version to 1.23

* Update CHANGELOG.next.asciidoc

* Update packaging.sh

* Update packaging.sh

* use the aarch image instead of the alias

* we don't use qemu on ARM64

* fix packaging

---------

Co-authored-by: Julien Lind <julien.lind@elastic.co>
Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com>
(cherry picked from commit eafca95)

# Conflicts:
#	libbeat/docs/version.asciidoc
mergify bot pushed a commit that referenced this pull request Mar 4, 2025
* feat: bump go version to 1.23

* Update CHANGELOG.next.asciidoc

* Update packaging.sh

* Update packaging.sh

* use the aarch image instead of the alias

* we don't use qemu on ARM64

* fix packaging

---------

Co-authored-by: Julien Lind <julien.lind@elastic.co>
Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com>
(cherry picked from commit eafca95)
@v1v
Copy link
Member

v1v commented Mar 4, 2025

I noticed an earlier failure for x-pack/osquerybeat which seems to have passed with the latest CI run which made me investigate a bit more; turns out that contrary to every other beat, we don't have a dedicated linux/arm64 packaging step for x-pack/osquerybeat either in DRA on in the PR packaging steps.

See #43019 is now the implementation.

Going forwards we probably want to file a ticket and implement this too, so that building arm64 for x-pack/osquerybeat is done without qemu emulation but inside a dedicated worker too (as done for every other beat).

I might say something a bit different and in my view, we might to revisit what's implemented and create a table or something that can allow us to know what stages run and when.

Back in the day, I used https://github.com/elastic/beats/blob/7.17/.ci/scripts/generate_build_table.py to create that table by reading all the Jenkinsfile.yml. I don't know whether that's something we can easily accomplish, but maybe something we can think about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch enhancement Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.