-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] system/auth module - Remove redundant grok wildcard #34550
[Filebeat] system/auth module - Remove redundant grok wildcard #34550
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
09d46d0
to
ed8bcfa
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
/test |
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same change needs to be made to the system integration at
The grok pattern of filebeat had a redundant operator in the pattern, %{SPACE}+, resulting in the regex (?:\s*)+ which has the + as a redundant operator. Co-authored-by: ShourieG <105607378+ShourieG@users.noreply.github.com>
What does this PR do?
The Grok pattern of filebeat had a redundant operator in the pattern, %{SPACE}+, resulting in the regex (?:\s*)+ which has the + as a redundant operator.
This issue is fixed by removing the redundant + operator.
Why is it important?
"Without this change, when the module's ingest pipelines are setup in Elasticsearch, the Elasticsearch server logs get flooded with warnings" #15900
Checklist
-[ ] I have commented my code, particularly in hard-to-understand areas-[ ] I have made corresponding changes to the documentation-[ ] I have made corresponding change to the default configuration files-[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
#34249, #15840
Closes #34249