Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system.auth] redundant wildcard in grok expression #5294

Closed
andrewkroh opened this issue Feb 16, 2023 · 1 comment · Fixed by #5320
Closed

[system.auth] redundant wildcard in grok expression #5294

andrewkroh opened this issue Feb 16, 2023 · 1 comment · Fixed by #5320
Assignees
@efd6
Labels
bug Something isn't working, use only for issues Integration:system System

Comments

@andrewkroh
Copy link
Member

The grok pattern has a redundant operator in the pattern, %{SPACE}+, resulting in the regex (?:\s*)+ which has the + as a redundant operator.

integrations/packages/system/data_stream/auth/elasticsearch/ingest_pipeline/default.yml

Line 17 in 5fca8c0

- '^%{TIMESTAMP:system.auth.timestamp} %{SYSLOGHOST:host.hostname}? %{DATA:process.name}(?:\[%{POSINT:process.pid:long}\])?:%{SPACE}+%{GREEDYMULTILINE:_temp.message}$'

Related
@andrewkroh andrewkroh added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:system System labels Feb 16, 2023
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 self-assigned this Feb 19, 2023
@efd6 efd6 mentioned this issue Feb 19, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efd6 efd6

Labels
bug Something isn't working, use only for issues Integration:system System
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

system/auth: remove redundant regular expression quantifier efd6/integrations
3 participants
@andrewkroh @elasticmachine @efd6