-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Manual backport][Heartbeat] Enable engine strict validation #34471
[Manual backport][Heartbeat] Enable engine strict validation #34471
Conversation
Pinging @elastic/uptime (Team:Uptime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test |
/test |
Test failures are unrelated, fix coming from #34501. |
This pull request is now in conflicts. Could you fix it? 🙏
|
What does this PR do?
Manual backport of elastic/elastic-agent#2225 and #34470.
Enable engine strict validation when bundling synthetics.
Why is it important?
https://discuss.elastic.co/t/synthetic-browser-tests-are-failing-in-version-7-x/324440/8
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Change node installed version to
NODE_VERSION=13.1.0
and build heartbeat docker image locally. It should fail with: