Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport][Heartbeat] Enable engine strict validation #34471

Merged
merged 6 commits into from
Feb 28, 2023

Conversation

emilioalvap
Copy link
Collaborator

@emilioalvap emilioalvap commented Feb 2, 2023

What does this PR do?

Manual backport of elastic/elastic-agent#2225 and #34470.
Enable engine strict validation when bundling synthetics.

Why is it important?

https://discuss.elastic.co/t/synthetic-browser-tests-are-failing-in-version-7-x/324440/8

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Change node installed version to NODE_VERSION=13.1.0 and build heartbeat docker image locally. It should fail with:

#22 2.226 npm verb stack Error: Unsupported engine for @elastic/synthetics@1.0.0-beta.40: wanted: {"node":">14.14.0"} (current: {"node":"13.1.0","npm":"6.12.1"})

@emilioalvap emilioalvap added bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team backport-skip Skip notification from the automated backport with mergify v7.17.0 labels Feb 2, 2023
@emilioalvap emilioalvap requested a review from a team as a code owner February 2, 2023 23:20
@emilioalvap emilioalvap requested review from rdner and cmacknz and removed request for a team February 2, 2023 23:20
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 2, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-27T17:41:58.586+0000

  • Duration: 200 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 22239
Skipped 1566
Total 23805

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmacknz cmacknz removed request for rdner and cmacknz February 6, 2023 20:24
@emilioalvap
Copy link
Collaborator Author

/test

@emilioalvap
Copy link
Collaborator Author

/test

@emilioalvap
Copy link
Collaborator Author

Test failures are unrelated, fix coming from #34501.

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b hb-backport-engine-strict upstream/hb-backport-engine-strict
git merge upstream/7.17
git push upstream hb-backport-engine-strict

@emilioalvap emilioalvap merged commit 3dbd8fb into elastic:7.17 Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants