Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce engine strict for synthetics install #34470

Merged
merged 7 commits into from
Feb 8, 2023
Merged

Enforce engine strict for synthetics install #34470

merged 7 commits into from
Feb 8, 2023

Conversation

emilioalvap
Copy link
Collaborator

@emilioalvap emilioalvap commented Feb 2, 2023 •
edited
Loading

What does this PR do?

Enables node engine validation when bundling synthetics.

Why is it important?

https://discuss.elastic.co/t/synthetic-browser-tests-are-failing-in-version-7-x/324440/8

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Change node installed version to NODE_VERSION=13.1.0 and build heartbeat docker image locally. It should fail with:

#22 2.226 npm verb stack Error: Unsupported engine for @elastic/synthetics@1.0.0-beta.40: wanted: {"node":">14.14.0"} (current: {"node":"13.1.0","npm":"6.12.1"})

@emilioalvap emilioalvap added bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.7.0 labels Feb 2, 2023
@emilioalvap emilioalvap requested a review from a team as a code owner February 2, 2023 22:13
@emilioalvap emilioalvap requested review from fearful-symmetry and faec and removed request for a team February 2, 2023 22:13
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 2, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 2, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @emilioalvap? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

vigneshshanmugam
vigneshshanmugam approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add it to the elastic agent image as well.

@emilioalvap emilioalvap mentioned this pull request Feb 2, 2023
Merged
6 tasks
@emilioalvap emilioalvap added backport-v8.6.0 Automated backport with mergify release-note:skip The PR should be ignored when processing the changelog labels Feb 2, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 2, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-08T11:06:10.126+0000

  • Duration: 105 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 25911
Skipped 1962
Total 27873

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@emilioalvap emilioalvap mentioned this pull request Feb 2, 2023
Merged
6 tasks
@emilioalvap emilioalvap merged commit be175b3 into elastic:main Feb 8, 2023
mergify bot pushed a commit that referenced this pull request Feb 8, 2023
@emilioalvap @mergify
Enforce engine strict for synthetics install (#34470)
c16d6c3 
* Enforce engine strict for synthetics install

* Add changelog

(cherry picked from commit be175b3)
@mergify mergify bot mentioned this pull request Feb 8, 2023
Merged
emilioalvap added a commit that referenced this pull request Feb 8, 2023
@mergify @emilioalvap
Enforce engine strict for synthetics install (#34470) (#34520)
484330e 
* Enforce engine strict for synthetics install

* Add changelog

(cherry picked from commit be175b3)

Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@emilioalvap @chrisberkhout
Enforce engine strict for synthetics install (#34470)
687dad1 
* Enforce engine strict for synthetics install

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@emilioalvap emilioalvap

Labels
backport-v8.6.0 Automated backport with mergify bug release-note:skip The PR should be ignored when processing the changelog Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilioalvap @elasticmachine @vigneshshanmugam