Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #23777 to 7.x: o365: Fix processing of ModifiedProperties field #23786

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Cherry-pick #23777 to 7.x: o365: Fix processing of ModifiedProperties field #23786

merged 1 commit into from
Feb 1, 2021

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Feb 1, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #23777 to 7.x branch. Original message:

What does this PR do?

Fixes a bug in the handling of ModifiedProperties field from O365 Management API events.

Why is it important?

This bug was causing the field to not be included in the resulting document.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@adriansr
o365: Fix processing of ModifiedProperties field (elastic#23777)
5e6785a 
A bug was causing entries for the ModifiedProperties field to be
dropped.

(cherry picked from commit 1f8a2e6)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 1, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23786 opened

    • Start Time: 2021-02-01T16:03:04.659+0000

  • Duration: 51 min 44 sec

  • Commit: 5e6785a

Test stats 🧪

Test Results
Failed 0
Passed 6741
Skipped 1049
Total 7790

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6741
Skipped 1049
Total 7790

@adriansr adriansr merged commit bce0439 into elastic:7.x Feb 1, 2021
@zube zube bot removed the [zube]: Done label May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriansr @elasticmachine @marc-gr