Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

o365: Fix processing of ModifiedProperties field #23777

Merged
merged 2 commits into from
Feb 1, 2021
Merged

o365: Fix processing of ModifiedProperties field #23777

merged 2 commits into from
Feb 1, 2021

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Feb 1, 2021 •
edited
Loading

What does this PR do?

Fixes a bug in the handling of ModifiedProperties field from O365 Management API events.

Why is it important?

This bug was causing the field to not be included in the resulting document.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@adriansr
o365: Fix processing of ModifiedProperties field
a9c297a 
A bug was causing entries for the ModifiedProperties field to be
dropped.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 1, 2021
@adriansr adriansr added bug needs_backport PR is waiting to be backported to other branches. review labels Feb 1, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 1, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23777 updated

    • Start Time: 2021-02-01T15:05:41.308+0000

  • Duration: 45 min 49 sec

  • Commit: 54276c8

Test stats 🧪

Test Results
Failed 0
Passed 6786
Skipped 1049
Total 7835

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6786
Skipped 1049
Total 7835

leehinman
leehinman approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriansr adriansr merged commit 1f8a2e6 into elastic:master Feb 1, 2021
@adriansr adriansr deleted the fix-o365-modified-properties branch February 1, 2021 15:58
adriansr added a commit to adriansr/beats that referenced this pull request Feb 1, 2021
@adriansr
o365: Fix processing of ModifiedProperties field (elastic#23777)
5e6785a 
A bug was causing entries for the ModifiedProperties field to be
dropped.

(cherry picked from commit 1f8a2e6)
@adriansr adriansr mentioned this pull request Feb 1, 2021
Merged
6 tasks
@adriansr adriansr added v7.12.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 1, 2021
adriansr added a commit to adriansr/beats that referenced this pull request Feb 1, 2021
@adriansr
o365: Fix processing of ModifiedProperties field (elastic#23777)
087b43a 
A bug was causing entries for the ModifiedProperties field to be
dropped.

(cherry picked from commit 1f8a2e6)
@adriansr adriansr mentioned this pull request Feb 1, 2021
Merged
6 tasks
adriansr added a commit that referenced this pull request Feb 1, 2021
@adriansr
o365: Fix processing of ModifiedProperties field (#23777) (#23787)
098acff 
A bug was causing entries for the ModifiedProperties field to be
dropped.

(cherry picked from commit 1f8a2e6)
adriansr added a commit that referenced this pull request Feb 1, 2021
@adriansr
o365: Fix processing of ModifiedProperties field (#23777) (#23786)
bce0439 
A bug was causing entries for the ModifiedProperties field to be
dropped.

(cherry picked from commit 1f8a2e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@leehinman leehinman leehinman approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry

Assignees
No one assigned
Labels
bug review v7.11.0 v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adriansr @elasticmachine @andrewkroh @leehinman