Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #23039 to 7.x: [Heartbeat] Make mime type response resolution always on #23043

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Cherry-pick #23039 to 7.x: [Heartbeat] Make mime type response resolution always on #23043

merged 1 commit into from
Dec 9, 2020

Conversation

andrewstucki
Copy link
Contributor

@andrewstucki andrewstucki commented Dec 9, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #23039 to 7.x branch. Original message:

What does this PR do?

This removes the optional processor in #22976 and makes mime type detection of responses mandatory using the same underlying code as the processor.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

[Heartbeat] Make mime type response resolution always on (elastic#23039)
6083ff8 
* [Heartbeat] Make mime type response resolution always on

* Add minimum buffer size

(cherry picked from commit 65616cd)
@andrewstucki andrewstucki requested a review from a team as a code owner December 9, 2020 20:29
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 9, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 9, 2020
andrewvc
andrewvc approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23043 opened

  • Start Time: 2020-12-09T20:29:46.499+0000

  • Duration: 31 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 932
Skipped 13
Total 945

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 932
Skipped 13
Total 945

@andrewstucki andrewstucki merged commit 11dc7bf into elastic:7.x Dec 9, 2020
@andrewstucki andrewstucki deleted the backport_23039_7.x branch December 9, 2020 21:18
@zube zube bot removed the [zube]: Done label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc andrewvc approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewstucki @elasticmachine @andrewvc