Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Add mime type detection #22976

Merged
merged 2 commits into from
Dec 9, 2020
Merged

[Heartbeat] Add mime type detection #22976

merged 2 commits into from
Dec 9, 2020

Conversation

andrewstucki
Copy link
Contributor

@andrewstucki andrewstucki commented Dec 8, 2020 •
edited
Loading

What does this PR do?

This adds ECS 1.7 mime_type detection for the response body of Heartbeat monitors.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@andrewstucki andrewstucki requested a review from a team as a code owner December 8, 2020 06:01
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 8, 2020
@andrewstucki andrewstucki mentioned this pull request Dec 8, 2020
Closed
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 8, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22976 updated

  • Start Time: 2020-12-08T06:04:18.668+0000

  • Duration: 21 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 932
Skipped 13
Total 945

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 932
Skipped 13
Total 945

@andrewstucki andrewstucki requested a review from a team December 9, 2020 02:07
@andrewstucki andrewstucki merged commit ad1d651 into elastic:master Dec 9, 2020
andrewstucki pushed a commit to andrewstucki/beats that referenced this pull request Dec 9, 2020
[Heartbeat] Add mime type detection (elastic#22976)
814f15e 
* Add mime type detection for heartbeat

* Update changelog

(cherry picked from commit ad1d651)
@andrewstucki andrewstucki mentioned this pull request Dec 9, 2020
Merged
6 tasks
andrewstucki pushed a commit that referenced this pull request Dec 9, 2020
[Heartbeat] Add mime type detection (#22976) (#23006)
36d51cb 
* Add mime type detection for heartbeat

* Update changelog

(cherry picked from commit ad1d651)
This was referenced Dec 9, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

Assignees
No one assigned
Labels
enhancement Heartbeat v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewstucki @elasticmachine @leehinman