Fix terminating pod autodiscover issue #20084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <chrismarkou92@gmail.com>
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
ChrsMark
added
needs_team
botelastic
bot
removed
the
needs_team
|
This pull request doesn't have a |
ChrsMark
added
v7.10.0
v7.9.0
autodiscovery
bug
needs_backport
Signed-off-by: chrismark <chrismarkou92@gmail.com>
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
--------------------- >> end captured stdout << ---------------------- Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
jsoriano
reviewed
Jul 22, 2020
There was a problem hiding this comment.
I think we should wait for the containers to be actually stopped before triggering a stop event. See my comment about this.
It would be also nice to have some tests to cover cases with termination grace periods, but this could go in a future change, this may be tricky to do.
Signed-off-by: chrismark <chrismarkou92@gmail.com>
|
Tested again after f62ca1e and issue is solved without the need of adding |
jsoriano
approved these changes
Jul 23, 2020
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Jul 23, 2020
(cherry picked from commit b561047)
3 tasks
ChrsMark
removed
the
needs_backport
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Jul 23, 2020
(cherry picked from commit b561047)
3 tasks
ChrsMark
added a commit
that referenced
this pull request
Jul 23, 2020
ChrsMark
added a commit
that referenced
this pull request
Jul 23, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 27, 2020
…ne-2.0 * upstream/master: (41 commits) adding possibility to override content-type checks, it was breaking certain webhooks that is not able to set content-headers at all. Still defaults to application/json (elastic#20232) fix: use a fixed worker type for tests (elastic#20130) [Ingest Manager] Prepare packaging for endpoint and asc files (elastic#20186) [Packetbeat] HTTP: Improve support for 100-continue elastic#15830 (elastic#19349) Increase index.max_docvalue_fields_search to 200 (elastic#20218) [Ingest Manager] Prevent closing closed reader (elastic#20214) [Metricbeat] Use MySQL Host Parser in Query metricset (elastic#20191) Testing: Ignore timestamp from cylance/protect dataset (elastic#20211) [Filebeat] Ignore cylance.protect timestamps while testing (elastic#20207) [CI] remove codecov step (elastic#20102) [docs] Indicate that SYSTEM user is required on Windows to use Endpoint (elastic#20172) Remove f5/firepass rsa2elk fileset (elastic#20160) [Elastic Agent] Improve GRPC stop to be more relaxed. (elastic#20118) Fix fileset field prefixing (elastic#20170) Fix terminating pod autodiscover issue (elastic#20084) Call host parser only once when building light metricsets (elastic#20149) [CI] fix null string with contains (elastic#20182) [Ingest Manager] Fix failing unit tests on windows (elastic#20127) [Filebeat] Update crowdstrike module (elastic#20138) [docs] Add x-pack role to relevant metricsets (elastic#20167) ...
|
7.9.0 have released, https://www.elastic.co/guide/en/beats/libbeat/7.9/release-notes-7.9.0.html。 |
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
|
@z521598 Looks like it is in the release notes:
|
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This addition handles the case when a Pod is in
Terminatingphase.In this case the pod is neither
PodSucceedednorPodFailedandhence requires special handling.
In this, we check all Pod's containers' statuses and if we find a at least
one still running we ignore this update event. With this, we make sure
that all containers are stopped before stopping Filebeat.
Why is it important?
To collect any leftover logs when the pod is going in Terminating state.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Use replication steps of #17396 (comment) and expect to see that the issue is fixed. The screenshot below provides the fixed case.
Related issues
Screenshots