Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19675 to 7.9: Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard #19979

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jul 16, 2020

Cherry-pick of PR #19675 to 7.9 branch. Original message:

Bug

What does this PR do?

The Kibana visualization CPU usage by node [Metricbeat Kubernetes] ECS did not account for x-axis scaling.
In case the scaling aligned with the value from metricset.period it was correct.
In every other case, the sum was not correctly calculated as it did not take into account how big the buckets in the visualizations would be.

Why is it important?

It allows to correctly see the usage of nodes on the Kubernetes Dashboard on longer time ranges.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

  • Load the dashboard and select a scaling that results in in non 10 seconds intervals for the visualization.

Screenshots

Confirmed working on non 10 seconds scaling.
image

…hboard (elastic#19675)

* Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard
The Kibana visualization CPU usage by node [Metricbeat Kubernetes] ECS did not account for x-axis scaling.
In case the scaling aligned with the value from metricset.period it was correct.
In every other case, the sum was not correctly calculated as it did not take into account how big the buckets in the visualizations would be.

* Add changelog entry for k8s dashboard node usage

(cherry picked from commit 4dcbde3)
@ChrsMark ChrsMark added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Jul 16, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 16, 2020
Copy link
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrsMark ChrsMark merged commit 2848ad7 into elastic:7.9 Jul 16, 2020
@zube zube bot removed the [zube]: Done label Oct 15, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…hboard (elastic#19675) (elastic#19979)

* Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard
The Kibana visualization CPU usage by node [Metricbeat Kubernetes] ECS did not account for x-axis scaling.
In case the scaling aligned with the value from metricset.period it was correct.
In every other case, the sum was not correctly calculated as it did not take into account how big the buckets in the visualizations would be.

* Add changelog entry for k8s dashboard node usage

(cherry picked from commit 114f78c)

Co-authored-by: Jasper Bernhardt <dihmandrake@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants