Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard #19675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
botelastic
bot
added
the
needs_team
|
💚 CLA has been signed |
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
…hboard The Kibana visualization CPU usage by node [Metricbeat Kubernetes] ECS did not account for x-axis scaling. In case the scaling aligned with the value from metricset.period it was correct. In every other case, the sum was not correctly calculated as it did not take into account how big the buckets in the visualizations would be.
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
|
Thanks for this PR @dihmandrake ! I think this is a valid change however @jsoriano could you please have a look too? |
|
jenkins run the tests please |
jsoriano
added
test-plan
jsoriano
approved these changes
Jul 9, 2020
metricbeat/module/kubernetes/_meta/kibana/7/dashboard/Metricbeat-kubernetes-overview.json
Show resolved
Hide resolved
|
@dihmandrake could you please add a changelog entry for this change? You can find an example at https://github.com/elastic/beats/pull/19913/files#diff-8a3db71464dcd8830047f8fb92084b27R574. Thanks! |
|
@ChrsMark I added an entry to the changelog file |
ChrsMark
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
Thanks for your contribution @dihmandrake! I will wait for CI and merge.
ChrsMark
pushed a commit
to ChrsMark/beats
that referenced
this pull request
Jul 16, 2020
…hboard (elastic#19675) * Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard The Kibana visualization CPU usage by node [Metricbeat Kubernetes] ECS did not account for x-axis scaling. In case the scaling aligned with the value from metricset.period it was correct. In every other case, the sum was not correctly calculated as it did not take into account how big the buckets in the visualizations would be. * Add changelog entry for k8s dashboard node usage (cherry picked from commit 4dcbde3)
6 tasks
ChrsMark
removed
the
needs_backport
ChrsMark
pushed a commit
to ChrsMark/beats
that referenced
this pull request
Jul 16, 2020
…hboard (elastic#19675) * Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard The Kibana visualization CPU usage by node [Metricbeat Kubernetes] ECS did not account for x-axis scaling. In case the scaling aligned with the value from metricset.period it was correct. In every other case, the sum was not correctly calculated as it did not take into account how big the buckets in the visualizations would be. * Add changelog entry for k8s dashboard node usage (cherry picked from commit 4dcbde3)
6 tasks
ChrsMark
added a commit
that referenced
this pull request
Jul 16, 2020
…hboard (#19675) (#19978) * Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard The Kibana visualization CPU usage by node [Metricbeat Kubernetes] ECS did not account for x-axis scaling. In case the scaling aligned with the value from metricset.period it was correct. In every other case, the sum was not correctly calculated as it did not take into account how big the buckets in the visualizations would be. * Add changelog entry for k8s dashboard node usage (cherry picked from commit 4dcbde3) Co-authored-by: Jasper Bernhardt <dihmandrake@users.noreply.github.com>
ChrsMark
added a commit
that referenced
this pull request
Jul 16, 2020
…hboard (#19675) (#19979) * Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard The Kibana visualization CPU usage by node [Metricbeat Kubernetes] ECS did not account for x-axis scaling. In case the scaling aligned with the value from metricset.period it was correct. In every other case, the sum was not correctly calculated as it did not take into account how big the buckets in the visualizations would be. * Add changelog entry for k8s dashboard node usage (cherry picked from commit 4dcbde3) Co-authored-by: Jasper Bernhardt <dihmandrake@users.noreply.github.com>
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 20, 2020
…ngs-archive * upstream/master: (274 commits) Test export commands in all Beats (elastic#20016) [Ingest Manager] Allow using drop path for agent build (elastic#20019) [DOCS] Remove include for deleted file in monitoring docs (elastic#20038) Removing xpack.monitoring.* settings (elastic#18608) [Heartbeat] Add service_name option for APM integration (elastic#19932) [Elastic Agent] Fix merging of fleet.yml. Add --staging to enroll cmd. (elastic#20026) Stricter stalebot configuration for PRs (elastic#20004) [ci] Favor direct mage invocation on CI (elastic#19960) Add cloudwatch input into Filebeat configure inputs documentation (elastic#19973) [Filebeat] remove delimiter \n from log line in s3 input (elastic#19972) [Metricbeat] Update MySQL dashboard (elastic#19913) Packetbeat process monitor: Ignore missing /proc/net/tcp6 (elastic#19945) [CI] fix MODULE variable cornercases (elastic#19985) Ignore timestamp in fortinet/clientendpoint and netscout/sightline (elastic#19998) add 7.9 to .backportrc.json (elastic#19952) Update internal links to external (elastic#19947) Remove Dynamic Script Compilations warning in Cisco module (elastic#19840) [Elastic Agent] Fix RPM and DEB packaging for Elastic Agent (elastic#19959) [Ingest Manager] Do not compare err with custom type (elastic#19980) Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard (elastic#19675) ...
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 20, 2020
…nly-mod * upstream/master: (75 commits) Test export commands in all Beats (elastic#20016) [Ingest Manager] Allow using drop path for agent build (elastic#20019) [DOCS] Remove include for deleted file in monitoring docs (elastic#20038) Removing xpack.monitoring.* settings (elastic#18608) [Heartbeat] Add service_name option for APM integration (elastic#19932) [Elastic Agent] Fix merging of fleet.yml. Add --staging to enroll cmd. (elastic#20026) Stricter stalebot configuration for PRs (elastic#20004) [ci] Favor direct mage invocation on CI (elastic#19960) Add cloudwatch input into Filebeat configure inputs documentation (elastic#19973) [Filebeat] remove delimiter \n from log line in s3 input (elastic#19972) [Metricbeat] Update MySQL dashboard (elastic#19913) Packetbeat process monitor: Ignore missing /proc/net/tcp6 (elastic#19945) [CI] fix MODULE variable cornercases (elastic#19985) Ignore timestamp in fortinet/clientendpoint and netscout/sightline (elastic#19998) add 7.9 to .backportrc.json (elastic#19952) Update internal links to external (elastic#19947) Remove Dynamic Script Compilations warning in Cisco module (elastic#19840) [Elastic Agent] Fix RPM and DEB packaging for Elastic Agent (elastic#19959) [Ingest Manager] Do not compare err with custom type (elastic#19980) Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard (elastic#19675) ...
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…hboard (elastic#19675) * Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard The Kibana visualization CPU usage by node [Metricbeat Kubernetes] ECS did not account for x-axis scaling. In case the scaling aligned with the value from metricset.period it was correct. In every other case, the sum was not correctly calculated as it did not take into account how big the buckets in the visualizations would be. * Add changelog entry for k8s dashboard node usage
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…hboard (elastic#19675) (elastic#19979) * Fix nanocore sum for non default intervals on Kubernetes Overview Dashboard The Kibana visualization CPU usage by node [Metricbeat Kubernetes] ECS did not account for x-axis scaling. In case the scaling aligned with the value from metricset.period it was correct. In every other case, the sum was not correctly calculated as it did not take into account how big the buckets in the visualizations would be. * Add changelog entry for k8s dashboard node usage (cherry picked from commit 114f78c) Co-authored-by: Jasper Bernhardt <dihmandrake@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
What does this PR do?
The Kibana visualization
CPU usage by node [Metricbeat Kubernetes] ECSdid not account for x-axis scaling.In case the scaling aligned with the value from metricset.period it was correct.
In every other case, the sum was not correctly calculated as it did not take into account how big the buckets in the visualizations would be.
Why is it important?
It allows to correctly see the usage of nodes on the Kubernetes Dashboard on longer time ranges.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Screenshots
Confirmed working on non 10 seconds scaling.
