Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Change visualization interval from 15m to >=15m #18466

Merged
merged 6 commits into from
May 13, 2020
Merged

[Metricbeat] Change visualization interval from 15m to >=15m #18466

merged 6 commits into from
May 13, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

This PR is to change visualization interval from a value to >= the value to avoid [tsvb] max_bucket exceeded error.

Before this change:
81604431-b8959b80-9384-11ea-9e1f-b80f34bc83d6

Quote from Chris on why this is happening:
The problem is the interval on all those visualizations is set to 15m instead of >=15m. When you increase the time range, you will eventually hit the circuit breakers because the time series produces too many buckets.

After this change:
Screen Shot 2020-05-12 at 4 16 23 PM

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 12, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this May 12, 2020
@kaiyan-sheng kaiyan-sheng added needs_backport PR is waiting to be backported to other branches. review Team:Platforms Label for the Integrations - Platforms team labels May 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 12, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 12, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by user kaiyan-sheng, Replayed apt repo #8]

  • Start Time: 2020-05-13T20:25:13.849+0000

  • Duration: 101 min 55 sec (6055133)

Test stats 🧪

Test Results
Failed 0
Passed 366
Skipped 39
Total 405

@ycombinator
Copy link
Contributor

In general, I'm wondering why we "hardcode" the intervals at all. Why not use auto and let Kibana figure out the optimal number of timeseries buckets to display based on the timepicker range?

@kaiyan-sheng
Copy link
Contributor Author

@ycombinator The problem I see with auto interval is it does not connect the dots with lines in visualize. For example,
With auto interval:
Screen Shot 2020-05-13 at 9 13 30 AM

With hardcoded >=5m interval:
Screen Shot 2020-05-13 at 9 13 08 AM

@ycombinator
Copy link
Contributor

Gotcha, thanks @kaiyan-sheng, let's stick with the "hardcoded" interval then.

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If possible, remove the searchSourceJSON changes but I don't think it's the end of the world if they make it in either.

@kaiyan-sheng
Copy link
Contributor Author

searchSourceJSON are all removed, thanks for reviewing!

@kaiyan-sheng kaiyan-sheng merged commit f90151c into elastic:master May 13, 2020
@kaiyan-sheng kaiyan-sheng deleted the gcp_storage_dashboard branch May 13, 2020 22:21
@kaiyan-sheng kaiyan-sheng added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels May 13, 2020
kaiyan-sheng added a commit that referenced this pull request May 14, 2020
…#18506)

* Change visualization interval from 15m to >=15m

(cherry picked from commit f90151c)
kaiyan-sheng added a commit that referenced this pull request May 14, 2020
…#18505)

* Change visualization interval from 15m to >=15m

(cherry picked from commit f90151c)
v1v added a commit to v1v/beats that referenced this pull request May 15, 2020
…w-oss

* upstream/master: (27 commits)
  Disable host fields for "cloud", panw, cef modules (elastic#18223)
  [docs] Rename monitoring collection from legacy internal collection to legacy collection (elastic#18504)
  Introduce auto detection of format (elastic#18095)
  Add additional fields to address issue elastic#18465 for googlecloud audit log (elastic#18472)
  Fix libbeat import path in seccomp policy template (elastic#18418)
  Address Okta input issue elastic#18530 (elastic#18534)
  [Ingest Manager] Avoid Chown on windows (elastic#18512)
  Fix Cisco ASA/FTD msgs that use a host name as NAT address (elastic#18376)
  [CI] Optimise stash/unstash performance (elastic#18473)
  Libbeat: Remove global loggers from libbeat/metric and libbeat/cloudid (elastic#18500)
  Fix PANW bad mapping of client/source and server/dest packets and bytes (elastic#18525)
  Add a file lock to the data directory on startup to prevent multiple agents. (elastic#18483)
  Followup to 12606 (elastic#18316)
  changed input from syslog to tcp/udp due to unsupported RFC (elastic#18447)
  Improve ECS field mappings in Sysmon module. (elastic#18381)
  [Elastic Agent] Cleaner output of inspect command  (elastic#18405)
  [Elastic Agent] Pick up version from libbeat (elastic#18350)
  Update communitybeats.asciidoc (elastic#18470)
  [Metricbeat] Change visualization interval from 15m to >=15m (elastic#18466)
  docs: Fix typo in kerberos docs (elastic#18503)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug review Team:Platforms Label for the Integrations - Platforms team v7.8.0 v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants