Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cisco ASA/FTD msgs that use a host name as NAT address #18376

Merged
merged 3 commits into from
May 14, 2020
Merged

Fix Cisco ASA/FTD msgs that use a host name as NAT address #18376

merged 3 commits into from
May 14, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented May 8, 2020 •
edited
Loading

What does this PR do?

Fixes the ingestion of Cisco ASA/FTD events that have a hostname as a NAT target, where an IP was expected.

Why is it important?

Because some NAT setups were causing ingestion failures.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@adriansr
Accept Cisco ASA/FTD msgs that use a host name as NAT address
084f8e2 
Sometimes the mapped source/destination IP field of an event is a hostname
instead of an IP address. This caused ingestion of the event to fail.

This patch makes the asa-ftd-pipeline to only populate those fields when
a valid IP address is found.

In the future we may want to revisit this if .nat.domain or
.nat.address fields become available.
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 8, 2020
@adriansr adriansr changed the title Accept Cisco ASA/FTD msgs that use a host name as NAT address Fix Cisco ASA/FTD msgs that use a host name as NAT address May 8, 2020
@adriansr adriansr added bug needs_backport PR is waiting to be backported to other branches. review Team:SIEM labels May 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@adriansr adriansr removed the needs_team Indicates that the issue/PR needs a Team:* label label May 8, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 8, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 2775
Skipped 418
Total 3193

Steps errors

Expand to view the steps failures

  • Name: Report to Codecov

    • Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done

    • Result: FAILURE

    • Duration: 1 min 27 sec

    • Start Time: 2020-05-08T14:25:45.037+0000

    • log

leehinman
leehinman approved these changes May 14, 2020
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriansr adriansr merged commit b24ed97 into elastic:master May 14, 2020
adriansr added a commit to adriansr/beats that referenced this pull request May 14, 2020
@adriansr
Fix Cisco ASA/FTD msgs that use a host name as NAT address (elastic#1…
a75ca1a 
…8376)

Sometimes the mapped source/destination IP field of an event is a hostname
instead of an IP address. This caused ingestion of the event to fail.

This patch makes the asa-ftd-pipeline to only populate those fields when
a valid IP address is found.

In the future we may want to revisit this if .nat.domain or
.nat.address fields become available.

(cherry picked from commit b24ed97)
@adriansr adriansr mentioned this pull request May 14, 2020
Merged
6 tasks
@adriansr adriansr added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels May 14, 2020
adriansr added a commit to adriansr/beats that referenced this pull request May 14, 2020
@adriansr
Fix Cisco ASA/FTD msgs that use a host name as NAT address (elastic#1…
ff20e7a 
…8376)

Sometimes the mapped source/destination IP field of an event is a hostname
instead of an IP address. This caused ingestion of the event to fail.

This patch makes the asa-ftd-pipeline to only populate those fields when
a valid IP address is found.

In the future we may want to revisit this if .nat.domain or
.nat.address fields become available.

(cherry picked from commit b24ed97)
@adriansr adriansr mentioned this pull request May 14, 2020
Merged
6 tasks
adriansr added a commit to adriansr/beats that referenced this pull request May 14, 2020
@adriansr
Fix Cisco ASA/FTD msgs that use a host name as NAT address (elastic#1…
5e71708 
…8376)

Sometimes the mapped source/destination IP field of an event is a hostname
instead of an IP address. This caused ingestion of the event to fail.

This patch makes the asa-ftd-pipeline to only populate those fields when
a valid IP address is found.

In the future we may want to revisit this if .nat.domain or
.nat.address fields become available.

(cherry picked from commit b24ed97)
@adriansr adriansr mentioned this pull request May 14, 2020
Merged
6 tasks
v1v added a commit to v1v/beats that referenced this pull request May 15, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/matrix-ne…
4d24ce8 
…w-oss

* upstream/master: (27 commits)
  Disable host fields for "cloud", panw, cef modules (elastic#18223)
  [docs] Rename monitoring collection from legacy internal collection to legacy collection (elastic#18504)
  Introduce auto detection of format (elastic#18095)
  Add additional fields to address issue elastic#18465 for googlecloud audit log (elastic#18472)
  Fix libbeat import path in seccomp policy template (elastic#18418)
  Address Okta input issue elastic#18530 (elastic#18534)
  [Ingest Manager] Avoid Chown on windows (elastic#18512)
  Fix Cisco ASA/FTD msgs that use a host name as NAT address (elastic#18376)
  [CI] Optimise stash/unstash performance (elastic#18473)
  Libbeat: Remove global loggers from libbeat/metric and libbeat/cloudid (elastic#18500)
  Fix PANW bad mapping of client/source and server/dest packets and bytes (elastic#18525)
  Add a file lock to the data directory on startup to prevent multiple agents. (elastic#18483)
  Followup to 12606 (elastic#18316)
  changed input from syslog to tcp/udp due to unsupported RFC (elastic#18447)
  Improve ECS field mappings in Sysmon module. (elastic#18381)
  [Elastic Agent] Cleaner output of inspect command  (elastic#18405)
  [Elastic Agent] Pick up version from libbeat (elastic#18350)
  Update communitybeats.asciidoc (elastic#18470)
  [Metricbeat] Change visualization interval from 15m to >=15m (elastic#18466)
  docs: Fix typo in kerberos docs (elastic#18503)
  ...
adriansr added a commit that referenced this pull request May 15, 2020
@adriansr
Fix Cisco ASA/FTD msgs that use a host name as NAT address (#18376) (#…
5112d7d 
…18546)

Sometimes the mapped source/destination IP field of an event is a hostname
instead of an IP address. This caused ingestion of the event to fail.

This patch makes the asa-ftd-pipeline to only populate those fields when
a valid IP address is found.

In the future we may want to revisit this if .nat.domain or
.nat.address fields become available.

(cherry picked from commit b24ed97)
adriansr added a commit that referenced this pull request May 15, 2020
@adriansr
Fix Cisco ASA/FTD msgs that use a host name as NAT address (#18376) (#…
810143b 
…18545)

Sometimes the mapped source/destination IP field of an event is a hostname
instead of an IP address. This caused ingestion of the event to fail.

This patch makes the asa-ftd-pipeline to only populate those fields when
a valid IP address is found.

In the future we may want to revisit this if .nat.domain or
.nat.address fields become available.

(cherry picked from commit b24ed97)
adriansr added a commit that referenced this pull request May 15, 2020
@adriansr
Fix Cisco ASA/FTD msgs that use a host name as NAT address (#18376) (#…
ee97368 
…18544)

Sometimes the mapped source/destination IP field of an event is a hostname
instead of an IP address. This caused ingestion of the event to fail.

This patch makes the asa-ftd-pipeline to only populate those fields when
a valid IP address is found.

In the future we may want to revisit this if .nat.domain or
.nat.address fields become available.

(cherry picked from commit b24ed97)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@adriansr
Fix Cisco ASA/FTD msgs that use a host name as NAT address (elastic#1…
38f064a 
…8376) (elastic#18546)

Sometimes the mapped source/destination IP field of an event is a hostname
instead of an IP address. This caused ingestion of the event to fail.

This patch makes the asa-ftd-pipeline to only populate those fields when
a valid IP address is found.

In the future we may want to revisit this if .nat.domain or
.nat.address fields become available.

(cherry picked from commit c4ccf2a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

Assignees
No one assigned
Labels
bug review v7.7.1 v7.8.0 v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filebeat - Cisco ASA Module rejected messages
3 participants
@adriansr @elasticmachine @leehinman