Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #18336 to 7.x: Add client address to events from http server module #18374

Merged
merged 1 commit into from
May 19, 2020
Merged

Cherry-pick #18336 to 7.x: Add client address to events from http server module #18374

merged 1 commit into from
May 19, 2020

Conversation

exekias
Copy link
Contributor

@exekias exekias commented May 8, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #18336 to 7.x branch. Original message:

  • Enhancement

What does this PR do?

Adds client address as service.address as part of events coming in from http server module

Why is it important?

It seems to be a gap in the module while things were moved to ECS

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 8, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 8, 2020 •
edited
Loading

❕ Build Aborted

Either there was a build timeout or someone aborted the build.'}

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-05-13T15:25:48.411+0000

  • Duration: 123 min 14 sec (7393718)

Log output

Expand to view the last 100 lines of log output 

[2020-05-13T16:44:43.582Z] Stage "Filebeat oss" skipped due to when conditional
[2020-05-13T16:44:43.582Z] Stage "Filebeat x-pack" skipped due to when conditional
[2020-05-13T16:44:43.585Z] Stage "Filebeat Mac OS X" skipped due to when conditional
[2020-05-13T16:44:43.586Z] Stage "Filebeat Windows" skipped due to when conditional
[2020-05-13T16:44:43.587Z] Stage "Heartbeat" skipped due to when conditional
[2020-05-13T16:44:43.588Z] Stage "Auditbeat oss" skipped due to when conditional
[2020-05-13T16:44:43.591Z] Stage "Auditbeat x-pack" skipped due to when conditional
[2020-05-13T16:44:43.593Z] Stage "Libbeat" skipped due to when conditional
[2020-05-13T16:44:43.595Z] Stage "Libbeat x-pack" skipped due to when conditional
[2020-05-13T16:44:43.604Z] Stage "Metricbeat Mac OS X" skipped due to when conditional
[2020-05-13T16:44:43.605Z] Stage "Packetbeat" skipped due to when conditional
[2020-05-13T16:44:43.610Z] Stage "dockerlogbeat" skipped due to when conditional
[2020-05-13T16:44:43.611Z] Stage "Winlogbeat" skipped due to when conditional
[2020-05-13T16:44:43.611Z] Stage "Winlogbeat Windows x-pack" skipped due to when conditional
[2020-05-13T16:44:43.615Z] Stage "Functionbeat" skipped due to when conditional
[2020-05-13T16:44:43.617Z] Stage "Journalbeat" skipped due to when conditional
[2020-05-13T16:44:43.618Z] Stage "Generators" skipped due to when conditional
[2020-05-13T16:44:43.619Z] Stage "Kubernetes" skipped due to when conditional
[2020-05-13T16:44:44.586Z] Stage "Heartbeat" skipped due to when conditional
[2020-05-13T16:44:44.588Z] Stage "Auditbeat oss" skipped due to when conditional
[2020-05-13T16:44:44.589Z] Stage "Libbeat" skipped due to when conditional
[2020-05-13T16:44:44.590Z] Stage "Packetbeat" skipped due to when conditional
[2020-05-13T16:44:44.594Z] Stage "dockerlogbeat" skipped due to when conditional
[2020-05-13T16:44:44.598Z] Stage "Winlogbeat" skipped due to when conditional
[2020-05-13T16:44:44.601Z] Stage "Functionbeat" skipped due to when conditional
[2020-05-13T16:44:44.605Z] Stage "Journalbeat" skipped due to when conditional
[2020-05-13T16:44:44.609Z] Stage "Generators" skipped due to when conditional
[2020-05-13T16:44:46.033Z] Stage "Heartbeat" skipped due to when conditional
[2020-05-13T16:44:46.035Z] Stage "Auditbeat oss" skipped due to when conditional
[2020-05-13T16:44:46.036Z] Stage "Libbeat" skipped due to when conditional
[2020-05-13T16:44:46.038Z] Stage "Winlogbeat" skipped due to when conditional
[2020-05-13T16:44:46.039Z] Stage "Functionbeat" skipped due to when conditional
[2020-05-13T16:44:46.040Z] Stage "Generators" skipped due to when conditional
[2020-05-13T16:44:47.196Z] Stage "Heartbeat" skipped due to when conditional
[2020-05-13T16:44:47.198Z] Stage "Auditbeat oss" skipped due to when conditional
[2020-05-13T16:44:47.199Z] Stage "Libbeat" skipped due to when conditional
[2020-05-13T16:44:47.201Z] Stage "Functionbeat" skipped due to when conditional
[2020-05-13T16:44:47.202Z] Stage "Generators" skipped due to when conditional
[2020-05-13T16:44:47.767Z] Stage "Auditbeat oss" skipped due to when conditional
[2020-05-13T16:44:47.769Z] Stage "Generators" skipped due to when conditional
[2020-05-13T16:44:58.694Z] Still waiting to schedule task
[2020-05-13T16:44:58.695Z] All nodes of label ‘ubuntu&&immutable’ are offline
[2020-05-13T16:44:58.697Z] Still waiting to schedule task
[2020-05-13T16:44:58.697Z] All nodes of label ‘ubuntu&&immutable’ are offline
[2020-05-13T16:44:58.700Z] Still waiting to schedule task
[2020-05-13T16:44:58.701Z] All nodes of label ‘ubuntu&&immutable’ are offline
[2020-05-13T16:44:58.708Z] Still waiting to schedule task
[2020-05-13T16:44:58.709Z] All nodes of label ‘ubuntu&&immutable’ are offline
[2020-05-13T16:44:58.861Z] Still waiting to schedule task
[2020-05-13T16:44:58.861Z] All nodes of label ‘ubuntu&&immutable’ are offline
[2020-05-13T16:44:59.301Z] Still waiting to schedule task
[2020-05-13T16:44:59.301Z] All nodes of label ‘windows-immutable&&windows-2019’ are offline
[2020-05-13T17:28:34.232Z] Cancelling nested steps due to timeout
[2020-05-13T17:28:37.399Z] Failed in branch Metricbeat OSS Unit tests
[2020-05-13T17:28:37.401Z] Failed in branch Metricbeat OSS Integration tests
[2020-05-13T17:28:37.402Z] Failed in branch Metricbeat Python integration tests
[2020-05-13T17:28:37.405Z] Failed in branch Metricbeat x-pack
[2020-05-13T17:28:37.406Z] Failed in branch Metricbeat crosscompile
[2020-05-13T17:28:37.411Z] Failed in branch Metricbeat Windows
[2020-05-13T17:28:38.105Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18374/src/github.com/elastic/beats
[2020-05-13T17:28:38.916Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-05-13T17:28:39.010Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18374/src/github.com/elastic/beats/Lint
[2020-05-13T17:28:40.049Z] + cat
[2020-05-13T17:28:40.049Z] + /usr/local/bin/runbld ./runbld-script
[2020-05-13T17:28:40.049Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-05-13T17:28:46.254Z] runbld>>> runbld started
[2020-05-13T17:28:46.254Z] runbld>>> 1.6.11/a66728ff8f4356963772e6e6d2069392fa06acbe
[2020-05-13T17:28:47.966Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-18374' in order of occurrence in the config (last value wins).
[2020-05-13T17:28:49.482Z] runbld>>> Debug logging enabled.
[2020-05-13T17:28:49.482Z] runbld>>> Storing result
[2020-05-13T17:28:49.482Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-05-13T17:28:49.482Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200513172848-1E53FEAB
[2020-05-13T17:28:49.482Z] runbld>>> Adding system facts.
[2020-05-13T17:28:50.218Z] runbld>>> Adding vcs info for the latest commit:  abefb731f35549111b00259319253b68ae4731c0
[2020-05-13T17:28:50.218Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-05-13T17:28:50.218Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-05-13T17:28:50.561Z] + echo 'Processing JUnit reports with runbld...'
[2020-05-13T17:28:50.561Z] Processing JUnit reports with runbld...
[2020-05-13T17:28:50.916Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-05-13T17:28:50.916Z] runbld>>> DURATION: 24ms
[2020-05-13T17:28:50.916Z] runbld>>> STDOUT: 40 bytes
[2020-05-13T17:28:50.916Z] runbld>>> STDERR: 49 bytes
[2020-05-13T17:28:50.916Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-05-13T17:28:50.916Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18374/src/github.com/elastic/beats
[2020-05-13T17:28:52.093Z] runbld>>> Storing build metadata: 
[2020-05-13T17:28:52.093Z] runbld>>> Adding test report.
[2020-05-13T17:28:52.093Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18374/src/github.com/elastic/beats
[2020-05-13T17:28:53.287Z] runbld>>> Found 0 test output files
[2020-05-13T17:28:53.287Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 0 Skipped: 0
[2020-05-13T17:28:53.659Z] runbld>>> Storing result
[2020-05-13T17:28:53.659Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-05-13T17:28:53.659Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200513172848-1E53FEAB
[2020-05-13T17:28:53.659Z] runbld>>> Email notification disabled by environment variable.
[2020-05-13T17:28:53.659Z] runbld>>> Slack notification disabled by environment variable.
[2020-05-13T17:29:00.231Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18374
[2020-05-13T17:29:00.853Z] [INFO] getVaultSecret: Getting secrets
[2020-05-13T17:29:00.993Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-05-13T17:29:02.455Z] + chmod 755 generate-build-data.sh
[2020-05-13T17:29:02.455Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18374/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18374/runs/4 ABORTED 7393718
[2020-05-13T17:29:03.006Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18374/runs/4/steps/?limit=10000 -o steps-info.json

ycombinator
ycombinator approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM.

@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label May 9, 2020
@exekias exekias merged commit c36648c into elastic:7.x May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees
No one assigned
Labels
backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@exekias @elasticmachine @ycombinator @andresrc @vjsamuel