Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client address to events from http server module #18336

Merged
merged 1 commit into from
May 8, 2020
Merged

Add client address to events from http server module #18336

merged 1 commit into from
May 8, 2020

Conversation

vjsamuel
Copy link
Contributor

@vjsamuel vjsamuel commented May 7, 2020 •
edited
Loading

  • Enhancement

What does this PR do?

Adds client address as service.address as part of events coming in from http server module

Why is it important?

It seems to be a gap in the module while things were moved to ECS

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 7, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 7, 2020 •
edited
Loading

💔 Build Failed

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Steps errors

Expand to view the steps failures

  • Name: Error signal

    • Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission

    • Result: FAILURE

    • Duration: 0 min 0 sec<

    • Start Time: 2020-05-07T06:15:24.496+0000

Log output

Expand to view the last 100 lines of log output 

[2020-05-07T06:15:20.900Z]  * [new tag]         v7.5.1     -> v7.5.1
[2020-05-07T06:15:20.900Z]  * [new tag]         v7.5.2     -> v7.5.2
[2020-05-07T06:15:20.900Z]  * [new tag]         v7.6.0     -> v7.6.0
[2020-05-07T06:15:20.900Z]  * [new tag]         v7.6.1     -> v7.6.1
[2020-05-07T06:15:20.900Z]  * [new tag]         v7.6.2     -> v7.6.2
[2020-05-07T06:15:20.900Z]  * [new tag]         v5.0.0-alpha5 -> v5.0.0-alpha5
[2020-05-07T06:15:21.701Z] + git rev-parse HEAD
[2020-05-07T06:15:22.070Z] + git rev-parse HEAD
[2020-05-07T06:15:22.373Z] + git rev-parse origin/pr/18336
[2020-05-07T06:15:22.442Z] [INFO] githubEnv: Found Git Build Cause: pr
[2020-05-07T06:15:23.068Z] Masking supported pattern matches of $GITHUB_TOKEN
[2020-05-07T06:15:24.103Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/beats/pulls/18336/reviews return 0 elements
[2020-05-07T06:15:24.175Z] [INFO] githubPrCheckApproved: Title: Add client address to events from http server module - User: vjsamuel - Author Association: CONTRIBUTOR
[2020-05-07T06:15:25.654Z] Stage "Lint" skipped due to earlier failure(s)
[2020-05-07T06:15:25.748Z] Stage "Build and Test" skipped due to earlier failure(s)
[2020-05-07T06:15:26.077Z] Stage "Elastic Agent x-pack" skipped due to earlier failure(s)
[2020-05-07T06:15:26.080Z] Stage "Elastic Agent x-pack Windows" skipped due to earlier failure(s)
[2020-05-07T06:15:26.082Z] Stage "Elastic Agent Mac OS X" skipped due to earlier failure(s)
[2020-05-07T06:15:26.083Z] Stage "Filebeat oss" skipped due to earlier failure(s)
[2020-05-07T06:15:26.085Z] Stage "Filebeat x-pack" skipped due to earlier failure(s)
[2020-05-07T06:15:26.086Z] Stage "Filebeat Mac OS X" skipped due to earlier failure(s)
[2020-05-07T06:15:26.088Z] Stage "Filebeat Windows" skipped due to earlier failure(s)
[2020-05-07T06:15:26.089Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:26.090Z] Stage "Auditbeat oss" skipped due to earlier failure(s)
[2020-05-07T06:15:26.091Z] Stage "Auditbeat x-pack" skipped due to earlier failure(s)
[2020-05-07T06:15:26.092Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:26.093Z] Stage "Libbeat x-pack" skipped due to earlier failure(s)
[2020-05-07T06:15:26.094Z] Stage "Metricbeat OSS Unit tests" skipped due to earlier failure(s)
[2020-05-07T06:15:26.095Z] Stage "Metricbeat OSS Integration tests" skipped due to earlier failure(s)
[2020-05-07T06:15:26.097Z] Stage "Metricbeat Python integration tests" skipped due to earlier failure(s)
[2020-05-07T06:15:26.098Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-05-07T06:15:26.099Z] Stage "Metricbeat crosscompile" skipped due to earlier failure(s)
[2020-05-07T06:15:26.100Z] Stage "Metricbeat Mac OS X" skipped due to earlier failure(s)
[2020-05-07T06:15:26.101Z] Stage "Metricbeat Windows" skipped due to earlier failure(s)
[2020-05-07T06:15:26.103Z] Stage "Packetbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:26.104Z] Stage "dockerlogbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:26.104Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:26.105Z] Stage "Winlogbeat Windows x-pack" skipped due to earlier failure(s)
[2020-05-07T06:15:26.107Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:26.108Z] Stage "Journalbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:26.109Z] Stage "Generators" skipped due to earlier failure(s)
[2020-05-07T06:15:26.109Z] Stage "Kubernetes" skipped due to earlier failure(s)
[2020-05-07T06:15:26.329Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:26.331Z] Stage "Auditbeat oss" skipped due to earlier failure(s)
[2020-05-07T06:15:26.332Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:26.334Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-05-07T06:15:26.335Z] Stage "Packetbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:26.336Z] Stage "dockerlogbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:26.338Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:26.341Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:26.343Z] Stage "Journalbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:26.344Z] Stage "Generators" skipped due to earlier failure(s)
[2020-05-07T06:15:26.926Z] Failed in branch Elastic Agent x-pack
[2020-05-07T06:15:26.927Z] Failed in branch Elastic Agent x-pack Windows
[2020-05-07T06:15:26.928Z] Failed in branch Elastic Agent Mac OS X
[2020-05-07T06:15:26.929Z] Failed in branch Filebeat oss
[2020-05-07T06:15:26.931Z] Failed in branch Filebeat x-pack
[2020-05-07T06:15:26.931Z] Failed in branch Filebeat Mac OS X
[2020-05-07T06:15:26.932Z] Failed in branch Filebeat Windows
[2020-05-07T06:15:26.933Z] Failed in branch Auditbeat x-pack
[2020-05-07T06:15:26.934Z] Failed in branch Libbeat x-pack
[2020-05-07T06:15:26.935Z] Failed in branch Metricbeat OSS Unit tests
[2020-05-07T06:15:26.936Z] Failed in branch Metricbeat OSS Integration tests
[2020-05-07T06:15:26.937Z] Failed in branch Metricbeat Python integration tests
[2020-05-07T06:15:26.940Z] Failed in branch Metricbeat crosscompile
[2020-05-07T06:15:26.941Z] Failed in branch Metricbeat Mac OS X
[2020-05-07T06:15:26.942Z] Failed in branch Metricbeat Windows
[2020-05-07T06:15:26.943Z] Failed in branch Winlogbeat Windows x-pack
[2020-05-07T06:15:26.944Z] Failed in branch Kubernetes
[2020-05-07T06:15:27.390Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:27.391Z] Stage "Auditbeat oss" skipped due to earlier failure(s)
[2020-05-07T06:15:27.393Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:27.394Z] Stage "Metricbeat x-pack" skipped due to earlier failure(s)
[2020-05-07T06:15:27.396Z] Stage "Winlogbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:27.397Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:27.398Z] Stage "Generators" skipped due to earlier failure(s)
[2020-05-07T06:15:27.536Z] Failed in branch Packetbeat
[2020-05-07T06:15:27.537Z] Failed in branch dockerlogbeat
[2020-05-07T06:15:27.539Z] Failed in branch Journalbeat
[2020-05-07T06:15:27.943Z] Stage "Heartbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:27.946Z] Stage "Auditbeat oss" skipped due to earlier failure(s)
[2020-05-07T06:15:27.949Z] Stage "Libbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:27.953Z] Stage "Functionbeat" skipped due to earlier failure(s)
[2020-05-07T06:15:27.955Z] Stage "Generators" skipped due to earlier failure(s)
[2020-05-07T06:15:28.021Z] Failed in branch Metricbeat x-pack
[2020-05-07T06:15:28.024Z] Failed in branch Winlogbeat
[2020-05-07T06:15:28.529Z] Failed in branch Heartbeat
[2020-05-07T06:15:28.530Z] Failed in branch Libbeat
[2020-05-07T06:15:28.531Z] Failed in branch Functionbeat
[2020-05-07T06:15:28.532Z] Stage "Auditbeat oss" skipped due to earlier failure(s)
[2020-05-07T06:15:28.533Z] Stage "Generators" skipped due to earlier failure(s)
[2020-05-07T06:15:28.727Z] Failed in branch Auditbeat oss
[2020-05-07T06:15:28.728Z] Failed in branch Generators
[2020-05-07T06:15:29.294Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18336
[2020-05-07T06:15:29.535Z] [INFO] getVaultSecret: Getting secrets
[2020-05-07T06:15:29.696Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-05-07T06:15:30.712Z] + chmod 755 generate-build-data.sh
[2020-05-07T06:15:30.712Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18336/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18336/runs/2 FAILURE 177469
[2020-05-07T06:15:31.263Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18336/runs/2/steps/?limit=10000 -o steps-info.json
[2020-05-07T06:15:32.606Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18336/runs/2/tests/?status=FAILED -o tests-errors.json

@exekias
Copy link
Contributor

exekias commented May 7, 2020

ok to test

@ChrsMark ChrsMark added the Team:Integrations Label for the Integrations team label May 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@ChrsMark ChrsMark added needs_backport PR is waiting to be backported to other branches. [zube]: In Review review labels May 7, 2020
@exekias
Copy link
Contributor

exekias commented May 7, 2020

jenkins test this please

@exekias exekias merged commit da1ba72 into elastic:master May 8, 2020
@exekias exekias mentioned this pull request May 8, 2020
Merged
6 tasks
@exekias exekias added v7.9.0 and removed needs_backport PR is waiting to be backported to other branches. labels May 8, 2020
exekias pushed a commit to exekias/beats that referenced this pull request May 8, 2020
@vjsamuel @exekias
Add client address to events from http server module (elastic#18336)
ecb05bb 
(cherry picked from commit da1ba72)
exekias pushed a commit that referenced this pull request May 19, 2020
@vjsamuel
Add client address to events from http server module (#18336) (#18374)
c36648c 
(cherry picked from commit da1ba72)

Co-authored-by: Vijay Samuel <vjsamuel@ebay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

Assignees
No one assigned
Labels
needs_team Indicates that the issue/PR needs a Team:* label review Team:Integrations Label for the Integrations team v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vjsamuel @elasticmachine @exekias @andresrc @ChrsMark