Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18026 to 7.x: Document recent changes to nginx fileset as breaking changes #18113

Merged
merged 1 commit into from
May 4, 2020

Conversation

leehinman
Copy link
Contributor

Cherry-pick of PR #18026 to 7.x branch. Original message:

What does this PR do?

PR #17844 introduced the following changes:

  • http.request.method is now lowercase
  • http.request.referrer is only set when nginx provides a value

This PR updates the CHANGELOG to report this as a breaking change.

Why is it important?

Notifies our users of a breaking change in behavior

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have made corresponding change to the default configuration files
- [ ] I have added tests that prove my fix is effective or that my feature works

  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related Issues

Relates #17844

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 29, 2020
…#18026)

PR elastic#17844 introduced the following changes:

- http.request.method is now lowercase
- http.request.referrer is only set when nginx provides a value

This PR updates the CHANGELOG to report this as a breaking change.

(cherry picked from commit 0de9b67)
@leehinman leehinman added Team:SIEM and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 29, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

  • Build Cause: [andrewkroh commented: run tests]

  • Start Time: 2020-05-04T13:40:33.019+0000

  • Duration: 27 min 15 sec (1635385)

  • Commit: 0b3ef1d

@andrewkroh
Copy link
Member

andrewkroh commented May 4, 2020

run tests

@leehinman leehinman merged commit a16b0fa into elastic:7.x May 4, 2020
@leehinman leehinman deleted the backport_18026_7.x branch May 4, 2020 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants